wip

Author: micheleorselli

src/CLI/Printer/GitlabPrinter.php

@@ -12,8 +12,8 @@ public function print(array $violationsCollection): string
         $allErrors = [];
 
         /**
-         * @var string      $key
-         * @var Violation[] $violationsByFqcn
+         * @var string           $key
+         * @var array<Violation> $violationsByFqcn
          */
         foreach ($violationsCollection as $class => $violationsByFqcn) {
             foreach ($violationsByFqcn as $violation) {

tests/E2E/Cli/CheckCommandTest.php

@@ -205,7 +205,7 @@ public function test_gitlab_format_output(): void
 
         $display = $cmdTester->getDisplay();
 
-        $this->assertJson($display);
+        self::assertJson($display);
 
         self::assertSame(<<<JSON
         [{"description":"should have a name that matches *Controller because all controllers should be end name with Controller","check_name":"App\\\\Controller\\\\Foo.should-have-a-name-that-matches-controller-because-all-controllers-should-be-end-name-with-controller","fingerprint":"1e960c3f49b5ec63ece40321072ef2bd0bc33ad11b7be326f304255d277dc860","severity":"major","location":{"path":"Controller\/Foo.php","lines":{"begin":1}}}]
@@ -223,10 +223,10 @@ public function test_gitlab_format_output_no_errors(): void
 
         $display = $cmdTester->getDisplay();
 
-        $this->assertJson($display);
+        self::assertJson($display);
 
         $json = json_decode($display, true);
-        $this->assertCount(0, $json);
+        self::assertCount(0, $json);
     }
 
     protected function runCheck(

tests/Unit/CLI/Printer/GitlabPrinterTest.php

@@ -44,10 +44,10 @@ public function test_print_with_no_violations(): void
 
         $result = $printer->print($violationsCollection);
 
-        $this->assertIsString($result, 'Result should be a string');
-        $this->assertJson($result, 'Result should be a valid JSON string');
+        self::assertIsString($result, 'Result should be a string');
+        self::assertJson($result, 'Result should be a valid JSON string');
 
         $decodedResult = json_decode($result, true);
-        $this->assertEmpty($decodedResult, 'Result should be an empty array');
+        self::assertEmpty($decodedResult, 'Result should be an empty array');
     }
 }