Runner class should know when stop (moves catch FailOnFirstViolationException) (#483)

Author: micheleorselli

src/CLI/Command/Check.php

@@ -10,7 +10,6 @@
 use Arkitect\CLI\Progress\ProgressBarProgress;
 use Arkitect\CLI\Runner;
 use Arkitect\CLI\TargetPhpVersion;
-use Arkitect\Exceptions\FailOnFirstViolationException;
 use Arkitect\Rules\ParsingErrors;
 use Arkitect\Rules\Violations;
 use Symfony\Component\Console\Command\Command;
@@ -150,10 +149,8 @@ protected function execute(InputInterface $input, OutputInterface $output): int
             $this->readRules($config, $rulesFilename);
 
             $runner = new Runner($stopOnFailure);
-            try {
-                $runner->run($config, $progress, $targetPhpVersion, $onlyErrors);
-            } catch (FailOnFirstViolationException $e) {
-            }
+            $runner->run($config, $progress, $targetPhpVersion, $onlyErrors);
+
             $violations = $runner->getViolations();
             $violations->sort();
 

src/CLI/Runner.php

@@ -41,7 +41,11 @@ public function run(Config $config, Progress $progress, TargetPhpVersion $target
                 $progress->startFileSetAnalysis($classSetRule->getClassSet());
             }
 
-            $this->check($classSetRule, $progress, $fileParser, $this->violations, $this->parsingErrors, $onlyErrors);
+            try {
+                $this->check($classSetRule, $progress, $fileParser, $this->violations, $this->parsingErrors, $onlyErrors);
+            } catch (FailOnFirstViolationException $e) {
+                return;
+            }
 
             if (!$onlyErrors) {
                 $progress->endFileSetAnalysis($classSetRule->getClassSet());