Fix code style

Author: Emil Masiakowski

.php-cs-fixer.dist.php

@@ -24,7 +24,7 @@
         'modernize_types_casting' => true, // Replaces intval, floatval, doubleval, strval and boolval function calls with according type casting operator.
         'multiline_whitespace_before_semicolons' => true, // Forbid multi-line whitespace before the closing semicolon or move the semicolon to the new line for chained calls.
         'no_unreachable_default_argument_value' => true, // In function arguments there must not be arguments with default values before non-default ones.
-	'no_superfluous_phpdoc_tags' => ['allow_mixed' => true],// To avoid problems of compatibility with the old php-cs-fixer version used on PHP 7.3
+        'no_superfluous_phpdoc_tags' => ['allow_mixed' => true], // To avoid problems of compatibility with the old php-cs-fixer version used on PHP 7.3
         'no_useless_else' => true,
         'no_useless_return' => true,
         'ordered_class_elements' => true, // Orders the elements of classes/interfaces/traits.
@@ -40,5 +40,8 @@
         'list_syntax' => ['syntax' => 'short'],
         'phpdoc_to_comment' => false,
         'php_unit_method_casing' => ['case' => 'snake_case'],
-        'function_to_constant' => false
+        'function_to_constant' => false,
+        'trailing_comma_in_multiline' => [
+            'elements' => ['array_destructuring', 'arrays'],
+        ],
     ]);

src/Analyzer/ClassDescription.php

@@ -44,7 +44,6 @@ class ClassDescription
     /**
      * @param list<ClassDependency>         $dependencies
      * @param list<FullyQualifiedClassName> $interfaces
-     * @param ?FullyQualifiedClassName      $extends
      * @param list<FullyQualifiedClassName> $attributes
      */
     public function __construct(

src/CLI/Command/Check.php

@@ -125,7 +125,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
             $this->printHeadingLine($output);
 
             $rulesFilename = $this->getConfigFilename($input);
-            $output->writeln(sprintf("Config file: %s\n", $rulesFilename));
+            $output->writeln(\sprintf("Config file: %s\n", $rulesFilename));
 
             $config = new Config();
 
@@ -239,14 +239,14 @@ private function getConfigFilename(InputInterface $input): string
     private function printViolations(Violations $violations, OutputInterface $output): void
     {
         $output->writeln('<error>ERRORS!</error>');
-        $output->writeln(sprintf('%s', $violations->toString()));
-        $output->writeln(sprintf('<error>%s VIOLATIONS DETECTED!</error>', \count($violations)));
+        $output->writeln(\sprintf('%s', $violations->toString()));
+        $output->writeln(\sprintf('<error>%s VIOLATIONS DETECTED!</error>', \count($violations)));
     }
 
     private function printParsedErrors(ParsingErrors $parsingErrors, OutputInterface $output): void
     {
         $output->writeln('<error>ERROR ON PARSING THESE FILES:</error>');
-        $output->writeln(sprintf('%s', $parsingErrors->toString()));
+        $output->writeln(\sprintf('%s', $parsingErrors->toString()));
     }
 
     private function printNoViolationsDetectedMessage(OutputInterface $output): void

src/CLI/PhpArkitectApplication.php

@@ -28,6 +28,6 @@ public function __construct()
 
     public function getLongVersion(): string
     {
-        return sprintf("%s\n\n<info>%s</info> version <comment>%s</comment>", self::$logo, $this->getName(), $this->getVersion());
+        return \sprintf("%s\n\n<info>%s</info> version <comment>%s</comment>", self::$logo, $this->getName(), $this->getVersion());
     }
 }

src/Exceptions/IndexNotFoundException.php

@@ -7,6 +7,6 @@ class IndexNotFoundException extends \Exception
 {
     public function __construct(int $index)
     {
-        parent::__construct(sprintf('Index not found %d', $index));
+        parent::__construct(\sprintf('Index not found %d', $index));
     }
 }

src/Exceptions/PhpVersionNotValidException.php

@@ -7,6 +7,6 @@ class PhpVersionNotValidException extends \Exception
 {
     public function __construct(string $phpVersion)
     {
-        parent::__construct(sprintf('PHP version not valid for PHPArkitect parser %s', $phpVersion));
+        parent::__construct(\sprintf('PHP version not valid for PHPArkitect parser %s', $phpVersion));
     }
 }

tests/Unit/Rules/ConstraintsTest.php

@@ -18,7 +18,7 @@ class ConstraintsTest extends TestCase
 {
     public function test_it_should_not_add_to_violation_if_constraint_is_not_violated(): void
     {
-        $trueExpression = new class() implements Expression {
+        $trueExpression = new class implements Expression {
             public function describe(ClassDescription $theClass, string $because): Description
             {
                 return new Description('', '');
@@ -48,7 +48,7 @@ public function evaluate(ClassDescription $theClass, Violations $violations, str
 
     public function test_it_should_add_to_violation_store_if_constraint_is_violated(): void
     {
-        $falseExpression = new class() implements Expression {
+        $falseExpression = new class implements Expression {
             public function describe(ClassDescription $theClass, string $because): Description
             {
                 return new Description('bar', 'we want to add this rule');