wip

Author: micheleorselli

src/CLI/Baseline.php

@@ -27,25 +27,30 @@ public function applyTo(Violations $violations, bool $ignoreBaselineLinenumbers)
         $violations->remove($this->violations, $ignoreBaselineLinenumbers);
     }
 
+    /**
+     * @psalm-suppress RiskyTruthyFalsyComparison
+     */
+    public static function resolveFilePath(?string $filePath, string $defaultFilePath): ?string
+    {
+        if (!$filePath && file_exists($defaultFilePath)) {
+            $filePath = $defaultFilePath;
+        }
+
+        return $filePath ?: null;
+    }
+
     public static function empty(): self
     {
         return new self(new Violations(), '');
     }
 
-    /**
-     * @psalm-suppress RiskyTruthyFalsyComparison
-     */
-    public static function create(bool $skipBaseline, ?string $baselineFilePath, string $defaultFilePath): self
+    public static function create(bool $skipBaseline, ?string $baselineFilePath): self
     {
-        if ($skipBaseline) {
+        if ($skipBaseline || null === $baselineFilePath) {
             return self::empty();
         }
 
-        if (!$baselineFilePath && file_exists($defaultFilePath)) {
-            $baselineFilePath = $defaultFilePath;
-        }
-
-        return $baselineFilePath ? self::loadFromFile($baselineFilePath) : self::empty();
+        return self::loadFromFile($baselineFilePath);
     }
 
     public static function loadFromFile(string $filename): self

src/CLI/Command/Check.php

@@ -5,7 +5,7 @@
 namespace Arkitect\CLI\Command;
 
 use Arkitect\CLI\Baseline;
-use Arkitect\CLI\Config;
+use Arkitect\CLI\ConfigBuilder;
 use Arkitect\CLI\Printer\PrinterFactory;
 use Arkitect\CLI\Progress\DebugProgress;
 use Arkitect\CLI\Progress\ProgressBarProgress;
@@ -16,7 +16,6 @@
 use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Output\ConsoleOutputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
-use Webmozart\Assert\Assert;
 
 class Check extends Command
 {
@@ -123,18 +122,21 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 
             $this->printHeadingLine($output);
 
-            $printer = (new PrinterFactory())->create($format);
+            $config = ConfigBuilder::loadFromFile($rulesFilename)
+                ->stopOnFailure($stopOnFailure)
+                ->targetPhpVersion(TargetPhpVersion::create($phpVersion))
+                ->baselineFilePath(Baseline::resolveFilePath($useBaseline, self::DEFAULT_BASELINE_FILENAME))
+                ->ignoreBaselineLinenumbers($ignoreBaselineLinenumbers)
+                ->skipBaseline($skipBaseline)
+                ->format($format);
 
-            $progress = $verbose ? new DebugProgress($output) : new ProgressBarProgress($output);
+            $printer = PrinterFactory::create($config->getFormat());
 
-            $baseline = Baseline::create($skipBaseline, $useBaseline, self::DEFAULT_BASELINE_FILENAME);
+            $progress = $verbose ? new DebugProgress($output) : new ProgressBarProgress($output);
 
-            $config = ConfigBuilder::loadFromFile($rulesFilename);
-            $config->stopOnFailure($stopOnFailure);
-            $config->targetPhpVersion(TargetPhpVersion::create($phpVersion));
-            $config->ignoreBaselineLinenumbers($ignoreBaselineLinenumbers);
+            $baseline = Baseline::create($config->isSkipBaseline(), $config->getBaselineFilePath());
 
-            $baseline->getFilename() && $output->writeln("Baseline file '{$baseline->getFilename()}' found");
+            null !== $config->getBaselineFilePath() && $output->writeln("Baseline file '{$config->getBaselineFilePath()}' found");
             $output->writeln("Config file '$rulesFilename' found\n");
 
             $runner = new Runner();
@@ -192,24 +194,3 @@ protected function printExecutionTime(OutputInterface $output, float $startTime)
         $output->writeln("⏱️ Execution time: $executionTime\n");
     }
 }
-
-class ConfigBuilder
-{
-    public static function loadFromFile(string $filePath): Config
-    {
-        Assert::file($filePath, "Config file '$filePath' not found");
-
-        $config = new Config();
-
-        \Closure::fromCallable(function () use ($config, $filePath): ?bool {
-            /** @psalm-suppress UnresolvableInclude $config */
-            $configFunction = require $filePath;
-
-            Assert::isCallable($configFunction);
-
-            return $configFunction($config);
-        })();
-
-        return $config;
-    }
-}

src/CLI/Config.php

@@ -5,6 +5,7 @@
 
 use Arkitect\ClassSet;
 use Arkitect\ClassSetRules;
+use Arkitect\CLI\Printer\PrinterFactory;
 use Arkitect\Rules\DSL\ArchRule;
 
 class Config
@@ -18,8 +19,14 @@ class Config
 
     private bool $stopOnFailure;
 
+    private bool $skipBaseline;
+
+    private ?string $baselineFilePath;
+
     private bool $ignoreBaselineLinenumbers;
 
+    private string $format;
+
     private TargetPhpVersion $targetPhpVersion;
 
     public function __construct()
@@ -28,7 +35,10 @@ public function __construct()
         $this->runOnlyARule = false;
         $this->parseCustomAnnotations = true;
         $this->stopOnFailure = false;
+        $this->skipBaseline = false;
+        $this->baselineFilePath = null;
         $this->ignoreBaselineLinenumbers = false;
+        $this->format = PrinterFactory::default();
         $this->targetPhpVersion = TargetPhpVersion::latest();
     }
 
@@ -83,16 +93,30 @@ public function getTargetPhpVersion(): TargetPhpVersion
         return $this->targetPhpVersion;
     }
 
-    public function stopOnFailure(bool $stopOnFailure): bool
+    public function stopOnFailure(bool $stopOnFailure): self
     {
-        return $this->stopOnFailure = $stopOnFailure;
+        $this->stopOnFailure = $stopOnFailure;
+
+        return $this;
     }
 
     public function isStopOnFailure(): bool
     {
         return $this->stopOnFailure;
     }
 
+    public function baselineFilePath(?string $baselineFilePath): self
+    {
+        $this->baselineFilePath = $baselineFilePath;
+
+        return $this;
+    }
+
+    public function getBaselineFilePath(): ?string
+    {
+        return $this->baselineFilePath;
+    }
+
     public function ignoreBaselineLinenumbers(bool $ignoreBaselineLinenumbers): self
     {
         $this->ignoreBaselineLinenumbers = $ignoreBaselineLinenumbers;
@@ -104,4 +128,28 @@ public function isIgnoreBaselineLinenumbers(): bool
     {
         return $this->ignoreBaselineLinenumbers;
     }
+
+    public function format(string $format): self
+    {
+        $this->format = $format;
+
+        return $this;
+    }
+
+    public function getFormat(): string
+    {
+        return $this->format;
+    }
+
+    public function skipBaseline(bool $skipBaseline): self
+    {
+        $this->skipBaseline = $skipBaseline;
+
+        return $this;
+    }
+
+    public function isSkipBaseline(): bool
+    {
+        return $this->skipBaseline;
+    }
 }

src/CLI/ConfigBuilder.php

@@ -0,0 +1,28 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Arkitect\CLI;
+
+use Webmozart\Assert\Assert;
+
+class ConfigBuilder
+{
+    public static function loadFromFile(string $filePath): Config
+    {
+        Assert::file($filePath, "Config file '$filePath' not found");
+
+        $config = new Config();
+
+        \Closure::fromCallable(function () use ($config, $filePath): ?bool {
+            /** @psalm-suppress UnresolvableInclude $config */
+            $configFunction = require $filePath;
+
+            Assert::isCallable($configFunction);
+
+            return $configFunction($config);
+        })();
+
+        return $config;
+    }
+}

src/CLI/Printer/PrinterFactory.php

@@ -5,7 +5,12 @@
 
 final class PrinterFactory
 {
-    public function create(string $format): Printer
+    public static function default(): string
+    {
+        return Printer::FORMAT_TEXT;
+    }
+
+    public static function create(string $format): Printer
     {
         switch ($format) {
             case Printer::FORMAT_GITLAB: