done

Author: micheleorselli

src/CLI/Command/Check.php

@@ -110,13 +110,19 @@ protected function execute(InputInterface $input, OutputInterface $output): int
             $useBaseline = (string) $input->getOption(self::USE_BASELINE_PARAM);
             $skipBaseline = (bool) $input->getOption(self::SKIP_BASELINE_PARAM);
             $ignoreBaselineLinenumbers = (bool) $input->getOption(self::IGNORE_BASELINE_LINENUMBERS_PARAM);
+            $phpVersion = $input->getOption('target-php-version');
             $format = $input->getOption(self::FORMAT_PARAM);
-            $onlyErrors = Printer::FORMAT_JSON === $format || Printer::FORMAT_GITLAB === $format;
 
             // we write everything on STDERR apart from the list of violations which goes on STDOUT
+            // this allows to pipe the output of this command to a file while showing output on the terminal
             $stdOut = $output;
             $output = $output instanceof ConsoleOutputInterface ? $output->getErrorOutput() : $output;
 
+            /** @var string|null $phpVersion */
+            $targetPhpVersion = TargetPhpVersion::create($phpVersion);
+
+            $progress = $verbose ? new DebugProgress($output) : new ProgressBarProgress($output);
+
             if (true !== $skipBaseline && !$useBaseline && file_exists(self::DEFAULT_BASELINE_FILENAME)) {
                 $useBaseline = self::DEFAULT_BASELINE_FILENAME;
             }
@@ -131,12 +137,6 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 
             $generateBaseline = $input->getOption(self::GENERATE_BASELINE_PARAM);
 
-            /** @var string|null $phpVersion */
-            $phpVersion = $input->getOption('target-php-version');
-            $targetPhpVersion = TargetPhpVersion::create($phpVersion);
-
-            $progress = $verbose ? new DebugProgress($output) : new ProgressBarProgress($output);
-
             $this->printHeadingLine($output);
 
             $rulesFilename = $this->getConfigFilename($input);
@@ -148,7 +148,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
             $this->readRules($config, $rulesFilename);
 
             $runner = new Runner($stopOnFailure);
-            $runner->run($config, $progress, $targetPhpVersion, $onlyErrors);
+            $runner->run($config, $progress, $targetPhpVersion);
 
             $violations = $runner->getViolations();
             $violations->sort();
@@ -255,8 +255,4 @@ private function getConfigFilename(InputInterface $input): string
 
         return $filename;
     }
-
-    private function printNoViolationsDetectedMessage(OutputInterface $output, bool $onlyErrors = false, string $format = Printer::FORMAT_TEXT): void
-    {
-    }
 }

src/CLI/Runner.php

@@ -30,26 +30,22 @@ public function __construct(bool $stopOnFailure = false)
         $this->parsingErrors = new ParsingErrors();
     }
 
-    public function run(Config $config, Progress $progress, TargetPhpVersion $targetPhpVersion, bool $onlyErrors): void
+    public function run(Config $config, Progress $progress, TargetPhpVersion $targetPhpVersion): void
     {
         /** @var FileParser $fileParser */
         $fileParser = FileParserFactory::createFileParser($targetPhpVersion, $config->isParseCustomAnnotationsEnabled());
 
         /** @var ClassSetRules $classSetRule */
         foreach ($config->getClassSetRules() as $classSetRule) {
-            if (!$onlyErrors) {
-                $progress->startFileSetAnalysis($classSetRule->getClassSet());
-            }
+            $progress->startFileSetAnalysis($classSetRule->getClassSet());
 
             try {
-                $this->check($classSetRule, $progress, $fileParser, $this->violations, $this->parsingErrors, $onlyErrors);
+                $this->check($classSetRule, $progress, $fileParser, $this->violations, $this->parsingErrors);
             } catch (FailOnFirstViolationException $e) {
                 return;
             }
 
-            if (!$onlyErrors) {
-                $progress->endFileSetAnalysis($classSetRule->getClassSet());
-            }
+            $progress->endFileSetAnalysis($classSetRule->getClassSet());
         }
     }
 
@@ -58,16 +54,13 @@ public function check(
         Progress $progress,
         Parser $fileParser,
         Violations $violations,
-        ParsingErrors $parsingErrors,
-        bool $onlyErrors = false
+        ParsingErrors $parsingErrors
     ): void {
         /** @var SplFileInfo $file */
         foreach ($classSetRule->getClassSet() as $file) {
             $fileViolations = new Violations();
 
-            if (!$onlyErrors) {
-                $progress->startParsingFile($file->getRelativePathname());
-            }
+            $progress->startParsingFile($file->getRelativePathname());
 
             $fileParser->parse($file->getContents(), $file->getRelativePathname());
             $parsedErrors = $fileParser->getParsingErrors();
@@ -91,9 +84,7 @@ public function check(
 
             $violations->merge($fileViolations);
 
-            if (!$onlyErrors) {
-                $progress->endParsingFile($file->getRelativePathname());
-            }
+            $progress->endParsingFile($file->getRelativePathname());
         }
     }