[ticket/17176] Update implementations to be compatible with Symfony 6.3

PHPBB3-17176

Author: marc1706

controller/resolver.php

@@ -65,10 +65,10 @@ public function __construct(ContainerInterface $container, $phpbb_root_path, \ph
 	* Load a controller callable
 	*
 	* @param Request $request Symfony Request object
-	* @return false|Callable Callable or false (fixme: method is returning an array)
+	* @return callable|false Callable or false
 	* @throws \phpbb\controller\exception
 	*/
-	public function getController(Request $request)
+	public function getController(Request $request): callable|false
 	{
 		$controller = $request->attributes->get('_controller');
 

di/extension/config.php

@@ -60,7 +60,7 @@ public function load(array $configs, ContainerBuilder $container)
 	*
 	* @return string The alias
 	*/
-	public function getAlias()
+	public function getAlias(): string
 	{
 		return 'config';
 	}

di/extension/core.php

@@ -144,7 +144,7 @@ public function getConfiguration(array $config, ContainerBuilder $container)
 	 *
 	 * @return string The alias
 	 */
-	public function getAlias()
+	public function getAlias(): string
 	{
 		return 'core';
 	}

di/extension/tables.php

@@ -52,7 +52,7 @@ public function load(array $configs, ContainerBuilder $container)
 	 *
 	 * @return string The alias
 	 */
-	public function getAlias()
+	public function getAlias(): string
 	{
 		return 'tables';
 	}

exception/http_exception.php

@@ -25,14 +25,14 @@ class http_exception extends runtime_exception implements HttpExceptionInterface
 	 *
 	 * @var integer
 	 */
-	private $status_code;
+	private int $status_code;
 
 	/**
 	 * Additional headers to set in the response.
 	 *
 	 * @var array
 	 */
-	private $headers;
+	private array $headers;
 
 	/**
 	 * Constructor
@@ -55,15 +55,15 @@ public function __construct($status_code, $message = "", array $parameters = arr
 	/**
 	 * {@inheritdoc}
 	 */
-	public function getStatusCode()
+	public function getStatusCode(): int
 	{
 		return $this->status_code;
 	}
 
 	/**
 	 * {@inheritdoc}
 	 */
-	public function getHeaders()
+	public function getHeaders(): array
 	{
 		return $this->headers;
 	}

extension/di/extension_base.php

@@ -132,7 +132,7 @@ public function getConfiguration(array $config, ContainerBuilder $container)
 	 *
 	 * @return string The alias
 	 */
-	public function getAlias()
+	public function getAlias(): string
 	{
 		return str_replace('/', '_', $this->extension_name);
 	}

routing/loader_resolver.php

@@ -33,7 +33,7 @@ public function __construct($loaders = [])
 	/**
 	 * {@inheritdoc}
 	 */
-	public function resolve($resource, $type = null)
+	public function resolve($resource, $type = null): false|\Symfony\Component\Config\Loader\LoaderInterface
 	{
 		/** @var \Symfony\Component\Config\Loader\LoaderInterface $loader */
 		foreach ($this->loaders as $loader)

routing/router.php

@@ -171,23 +171,23 @@ public function setContext(RequestContext $context)
 	/**
 	 * {@inheritdoc}
 	 */
-	public function getContext()
+	public function getContext(): RequestContext
 	{
 		return $this->context;
 	}
 
 	/**
 	 * {@inheritdoc}
 	 */
-	public function generate($name, $parameters = array(), $referenceType = self::ABSOLUTE_PATH)
+	public function generate(string $name, array $parameters = [], int $referenceType = self::ABSOLUTE_PATH): string
 	{
 		return $this->get_generator()->generate($name, $parameters, $referenceType);
 	}
 
 	/**
 	 * {@inheritdoc}
 	 */
-	public function match($pathinfo)
+	public function match(string $pathinfo): array
 	{
 		return $this->get_matcher()->match($pathinfo);
 	}