[ticket/17361] Fix file not deleted when there is an error

rubencm · rubencm · commit 34308d10a352 · 2025-01-19T21:09:36.000+01:00
PHPBB-17361
diff --git a/files/filespec_storage.php b/files/filespec_storage.php
@@ -447,6 +447,7 @@ public function move_file($storage, $overwrite = false, $skip_image_check = fals
 			$fp = fopen($this->filename, 'rb');
 
 			$storage->write($this->destination_file, $fp);
+			$this->file_moved = true;
 		}
 		catch (\phpbb\storage\exception\storage_exception $e)
 		{

Original file line number	Diff line number	Diff line change
`@@ -447,6 +447,7 @@ public function move_file($storage, $overwrite = false, $skip_image_check = fals`
`447`	`447`	`$fp = fopen($this->filename, 'rb');`
`448`	`448`
`449`	`449`	`$storage->write($this->destination_file, $fp);`
	`450`	`+ $this->file_moved = true;`
`450`	`451`	`}`
`451`	`452`	`catch (\phpbb\storage\exception\storage_exception $e)`
`452`	`453`	`{`