[ticket/17336] Also check for compatible extension by PHP version

iMattPro · iMattPro · commit c94d97aa28dd · 2024-06-12T06:42:38.000-07:00
PHPBB-17336

Signed-off-by: Matt Friedman &lt;maf675@gmail.com&gt;
diff --git a/composer/installer.php b/composer/installer.php
@@ -514,6 +514,17 @@ private function get_compatible_versions(array $compatible_packages, ConstraintI
 					}
 				}
 
+				// Check for compatibility with php if 'php' exists in 'requires'
+				if (isset($requires['php']))
+				{
+					$php_constraint = $version_parser->parseConstraints(PHP_VERSION);
+					$package_constraint = $requires['php']->getConstraint();
+					if (!$package_constraint->matches($php_constraint))
+					{
+						continue;
+					}
+				}
+
 				$compatible_packages[$package_name][] = $version;
 			}
 			catch (\Exception $e)

Original file line number	Diff line number	Diff line change
`@@ -514,6 +514,17 @@ private function get_compatible_versions(array $compatible_packages, ConstraintI`
`514`	`514`	`}`
`515`	`515`	`}`
`516`	`516`
	`517`	`+ // Check for compatibility with php if 'php' exists in 'requires'`
	`518`	`+ if (isset($requires['php']))`
	`519`	`+ {`
	`520`	`+ $php_constraint = $version_parser->parseConstraints(PHP_VERSION);`
	`521`	`+ $package_constraint = $requires['php']->getConstraint();`
	`522`	`+ if (!$package_constraint->matches($php_constraint))`
	`523`	`+ {`
	`524`	`+ continue;`
	`525`	`+ }`
	`526`	`+ }`
	`527`	`+`
`517`	`528`	`$compatible_packages[$package_name][] = $version;`
`518`	`529`	`}`
`519`	`530`	`catch (\Exception $e)`