tidy: move to GT namespace

g105b · g105b · commit 78fe75722d9f · 2025-10-18T13:45:09.000+01:00
diff --git a/composer.json b/composer.json
@@ -54,12 +54,12 @@
 
 	"autoload": {
 		"psr-4": {
-			"Gt\\WebEngine\\": "./src/"
+			"GT\\WebEngine\\": "./src/"
 		}
 	},
 	"autoload-dev": {
 		"psr-4": {
-			"Gt\\WebEngine\\Test\\": "./test/phpunit"
+			"GT\\WebEngine\\Test\\": "./test/phpunit"
 		}
 	},
 
diff --git a/src/Application.php b/src/Application.php
@@ -1,10 +1,15 @@
 <?php
-namespace Gt\WebEngine;
+namespace GT\WebEngine;
 
-use Gt\WebEngine\Debug\OutputBuffer;
-use Gt\WebEngine\Debug\Timer;
-use Gt\WebEngine\Redirection\Redirect;
+use GT\WebEngine\Debug\OutputBuffer;
+use GT\WebEngine\Debug\Timer;
+use GT\WebEngine\Redirection\Redirect;
 
+/**
+ * The fundamental purpose of any PHP framework is to provide a mechanism for
+ * generating an HTTP response from an incoming HTTP request. This functionality
+ * is what's wrapped into the WebEngine Application class here.
+ */
 class Application {
 	private Redirect $redirect;
 	private Timer $timer;
diff --git a/src/Debug/OutputBuffer.php b/src/Debug/OutputBuffer.php
@@ -1,5 +1,5 @@
 <?php
-namespace Gt\WebEngine\Debug;
+namespace GT\WebEngine\Debug;
 
 use Closure;
 
diff --git a/src/Debug/Timer.php b/src/Debug/Timer.php
@@ -1,5 +1,5 @@
 <?php
-namespace Gt\WebEngine\Debug;
+namespace GT\WebEngine\Debug;
 
 use Closure;
 
diff --git a/src/Redirection/DelimitedRedirectLoader.php b/src/Redirection/DelimitedRedirectLoader.php
@@ -1,5 +1,5 @@
 <?php
-namespace Gt\WebEngine\Redirection;
+namespace GT\WebEngine\Redirection;
 
 readonly class DelimitedRedirectLoader implements RedirectLoader {
 	public function __construct(private string $delimiter) {}
@@ -10,7 +10,7 @@ public function load(string $file, RedirectMap $map):void {
 			return;
 		}
 
-		while(($row = fgetcsv($fileHandle, 0, $this->delimiter, escape: '\\')) !== false) {
+		while(($row = fgetcsv($fileHandle, 0, $this->delimiter, escape: '')) !== false) {
 			if(count($row) < 2) {
 				continue;
 			}
diff --git a/src/Redirection/IniRedirectLoader.php b/src/Redirection/IniRedirectLoader.php
@@ -1,5 +1,5 @@
 <?php
-namespace Gt\WebEngine\Redirection;
+namespace GT\WebEngine\Redirection;
 
 class IniRedirectLoader implements RedirectLoader {
 	public function load(string $file, RedirectMap $map):void {
diff --git a/src/Redirection/Redirect.php b/src/Redirection/Redirect.php
@@ -1,5 +1,5 @@
 <?php
-namespace Gt\WebEngine\Redirection;
+namespace GT\WebEngine\Redirection;
 
 use Closure;
 
diff --git a/src/Redirection/RedirectException.php b/src/Redirection/RedirectException.php
@@ -1,6 +1,6 @@
 <?php
-namespace Gt\WebEngine\Redirection;
+namespace GT\WebEngine\Redirection;
 
-use Gt\WebEngine\WebEngineException;
+use GT\WebEngine\WebEngineException;
 
 class RedirectException extends WebEngineException {}
diff --git a/src/Redirection/RedirectLoader.php b/src/Redirection/RedirectLoader.php
@@ -1,5 +1,5 @@
 <?php
-namespace Gt\WebEngine\Redirection;
+namespace GT\WebEngine\Redirection;
 
 interface RedirectLoader {
 	public function load(string $file, RedirectMap $map):void;
diff --git a/src/Redirection/RedirectMap.php b/src/Redirection/RedirectMap.php
@@ -1,5 +1,5 @@
 <?php
-namespace Gt\WebEngine\Redirection;
+namespace GT\WebEngine\Redirection;
 
 class RedirectMap {
 	/** @var array<int, array<string, string>> */
diff --git a/src/Redirection/RedirectUri.php b/src/Redirection/RedirectUri.php
@@ -1,5 +1,5 @@
 <?php
-namespace Gt\WebEngine\Redirection;
+namespace GT\WebEngine\Redirection;
 
 class RedirectUri {
 	public function __construct(
diff --git a/src/Redirection/StatusCodeValidator.php b/src/Redirection/StatusCodeValidator.php
@@ -1,15 +1,16 @@
 <?php
-namespace Gt\WebEngine\Redirection;
+namespace GT\WebEngine\Redirection;
 
-final class StatusCodeValidator {
-	public const DEFAULT_CODE = 307;
-	public const MIN_CODE = 301;
-	public const MAX_CODE = 308;
+class StatusCodeValidator {
+	public const int DEFAULT_CODE = 307;
+	public const int MIN_CODE = 301;
+	public const int MAX_CODE = 308;
 
 	public static function validate(mixed $raw):int {
 		if(!filter_var($raw, FILTER_VALIDATE_INT) || $raw < self::MIN_CODE || $raw > self::MAX_CODE) {
 			throw new RedirectException("Invalid HTTP status code in redirect file: $raw");
 		}
+
 		return (int)$raw;
 	}
 }
diff --git a/src/WebEngineException.php b/src/WebEngineException.php
@@ -1,4 +1,4 @@
 <?php
-namespace Gt\WebEngine;
+namespace GT\WebEngine;
 
 class WebEngineException extends \Exception {}
diff --git a/test/phpunit/Debug/OutputBufferTest.php b/test/phpunit/Debug/OutputBufferTest.php
@@ -1,7 +1,7 @@
 <?php
-namespace Gt\WebEngine\Test\Debug;
+namespace GT\WebEngine\Test\Debug;
 
-use Gt\WebEngine\Debug\OutputBuffer;
+use GT\WebEngine\Debug\OutputBuffer;
 use PHPUnit\Framework\TestCase;
 
 class OutputBufferTest extends TestCase {
diff --git a/test/phpunit/Debug/TimerTest.php b/test/phpunit/Debug/TimerTest.php
@@ -1,7 +1,7 @@
 <?php
-namespace Gt\WebEngine\Test\Debug;
+namespace GT\WebEngine\Test\Debug;
 
-use Gt\WebEngine\Debug\Timer;
+use GT\WebEngine\Debug\Timer;
 use PHPUnit\Framework\TestCase;
 
 class TimerTest extends TestCase {
diff --git a/test/phpunit/Redirection/DelimitedRedirectLoaderTest.php b/test/phpunit/Redirection/DelimitedRedirectLoaderTest.php
@@ -1,9 +1,9 @@
 <?php
-namespace Gt\WebEngine\Test\Redirection;
+namespace GT\WebEngine\Test\Redirection;
 
-use Gt\WebEngine\Redirection\DelimitedRedirectLoader;
-use Gt\WebEngine\Redirection\RedirectException;
-use Gt\WebEngine\Redirection\RedirectMap;
+use GT\WebEngine\Redirection\DelimitedRedirectLoader;
+use GT\WebEngine\Redirection\RedirectException;
+use GT\WebEngine\Redirection\RedirectMap;
 use PHPUnit\Framework\TestCase;
 
 class DelimitedRedirectLoaderTest extends TestCase {
diff --git a/test/phpunit/Redirection/IniRedirectLoaderTest.php b/test/phpunit/Redirection/IniRedirectLoaderTest.php
@@ -1,9 +1,9 @@
 <?php
-namespace Gt\WebEngine\Test\Redirection;
+namespace GT\WebEngine\Test\Redirection;
 
-use Gt\WebEngine\Redirection\IniRedirectLoader;
-use Gt\WebEngine\Redirection\RedirectException;
-use Gt\WebEngine\Redirection\RedirectMap;
+use GT\WebEngine\Redirection\IniRedirectLoader;
+use GT\WebEngine\Redirection\RedirectException;
+use GT\WebEngine\Redirection\RedirectMap;
 use PHPUnit\Framework\TestCase;
 
 class IniRedirectLoaderTest extends TestCase {
diff --git a/test/phpunit/Redirection/RedirectExceptionTest.php b/test/phpunit/Redirection/RedirectExceptionTest.php
@@ -1,8 +1,8 @@
 <?php
-namespace Gt\WebEngine\Test\Redirection;
+namespace GT\WebEngine\Test\Redirection;
 
-use Gt\WebEngine\Redirection\RedirectException;
-use Gt\WebEngine\WebEngineException;
+use GT\WebEngine\Redirection\RedirectException;
+use GT\WebEngine\WebEngineException;
 use PHPUnit\Framework\TestCase;
 
 class RedirectExceptionTest extends TestCase {
diff --git a/test/phpunit/Redirection/RedirectMapTest.php b/test/phpunit/Redirection/RedirectMapTest.php
@@ -1,9 +1,9 @@
 <?php
-namespace Gt\WebEngine\Test\Redirection;
+namespace GT\WebEngine\Test\Redirection;
 
-use Gt\WebEngine\Redirection\RedirectException;
-use Gt\WebEngine\Redirection\RedirectMap;
-use Gt\WebEngine\Redirection\RedirectUri;
+use GT\WebEngine\Redirection\RedirectException;
+use GT\WebEngine\Redirection\RedirectMap;
+use GT\WebEngine\Redirection\RedirectUri;
 use PHPUnit\Framework\Attributes\IgnorePhpunitWarnings;
 use PHPUnit\Framework\Attributes\WithoutErrorHandler;
 use PHPUnit\Framework\TestCase;
diff --git a/test/phpunit/Redirection/RedirectTest.php b/test/phpunit/Redirection/RedirectTest.php
@@ -1,8 +1,8 @@
 <?php
-namespace Gt\WebEngine\Test\Redirection;
+namespace GT\WebEngine\Test\Redirection;
 
-use Gt\WebEngine\Redirection\Redirect;
-use Gt\WebEngine\Redirection\RedirectException;
+use GT\WebEngine\Redirection\Redirect;
+use GT\WebEngine\Redirection\RedirectException;
 use PHPUnit\Framework\TestCase;
 
 class RedirectTest extends TestCase {
diff --git a/test/run b/test/run

Original file line number	Diff line number	Diff line change
`@@ -54,12 +54,12 @@`
`54`	`54`
`55`	`55`	`"autoload": {`
`56`	`56`	`"psr-4": {`
`57`		`- "Gt\\WebEngine\\": "./src/"`
	`57`	`+ "GT\\WebEngine\\": "./src/"`
`58`	`58`	`}`
`59`	`59`	`},`
`60`	`60`	`"autoload-dev": {`
`61`	`61`	`"psr-4": {`
`62`		`- "Gt\\WebEngine\\Test\\": "./test/phpunit"`
	`62`	`+ "GT\\WebEngine\\Test\\": "./test/phpunit"`
`63`	`63`	`}`
`64`	`64`	`},`
`65`	`65`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`<?php`
`2`		`-namespace Gt\WebEngine\Redirection;`
	`2`	`+namespace GT\WebEngine\Redirection;`
`3`	`3`
`4`	`4`	`readonly class DelimitedRedirectLoader implements RedirectLoader {`
`5`	`5`	`public function __construct(private string $delimiter) {}`
`@@ -10,7 +10,7 @@ public function load(string $file, RedirectMap $map):void {`
`10`	`10`	`return;`
`11`	`11`	`}`
`12`	`12`
`13`		`- while(($row = fgetcsv($fileHandle, 0, $this->delimiter, escape: '\\')) !== false) {`
	`13`	`+ while(($row = fgetcsv($fileHandle, 0, $this->delimiter, escape: '')) !== false) {`
`14`	`14`	`if(count($row) < 2) {`
`15`	`15`	`continue;`
`16`	`16`	`}`