Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix removed symfony deprecations #24

Merged
merged 6 commits into from
Feb 23, 2024
Merged

Fix removed symfony deprecations #24

merged 6 commits into from
Feb 23, 2024

Conversation

filippeb
Copy link
Contributor

@filippeb filippeb commented Feb 22, 2024

Q A
Type improvement
BC Break yes
Fixed issues

Summary

Update minimum package version symfony/http-kernel: 6.4, 7.0

  • source dep: symfony/http-foundation: $request->getContentTypeFormat (available from 5.4, 6.2, 7.0)
  • test dep: symfony/http-kernel: HttpKernelInterface::MAIN_REQUEST (available from 5.3)
  • applied cs rules

@filippeb filippeb marked this pull request as ready for review February 22, 2024 13:43
@veewee
Copy link
Contributor

veewee commented Feb 22, 2024

$request->getContentTypeFormat is only available from sf 6.2 and is not available in 5.4.

Would it make sense to allow ^6.4|^7.0 only?
People on lower versions can use an older version of this repo.

6.0-6.3 is not supported anymore.
5.4 is still LTS for 2 years, but they can use an older version of this repo without problems.

@filippeb
Copy link
Contributor Author

That's possible, updated the PR.

@veewee veewee added the enhancement New feature or request label Feb 23, 2024
@veewee
Copy link
Contributor

veewee commented Feb 23, 2024

@filippeb can you fix the code-style issues

@veewee veewee merged commit a153e5e into phpro:master Feb 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants