Resolve methodcall args in QueryBuilderType with proper Scope #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ondrejmirtes
requested changes
Jan 9, 2024
| @@ -48,7 +48,8 @@ public function getTypeFromMethodCall( | |||
| } | |||
|
|
|||
| return new $class( | |||
| $this->queryBuilderClass ?? 'Doctrine\ORM\QueryBuilder' | |||
| $this->queryBuilderClass ?? 'Doctrine\ORM\QueryBuilder', | |||
| $scope | |||
There was a problem hiding this comment.
To pass Scope in a type is weird. Perhaps we should do argumentsProcessor->processArgs sooner and carry the final args in the Type? Or something different like that.
There was a problem hiding this comment.
That was my original thought, but this felt easier. Anyway, do you see any real issue with this approach?
There was a problem hiding this comment.
Btw to fix the failing tests, I probably need to store Scope per the method call inside.
There was a problem hiding this comment.
I feel like this is still going to be wrong in some cases, as the failing tests prove. One Scope per QueryBuilder is not enough as the scope changes when the QB gets built. Better process the args sooner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #512