Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support negative lags in RV calculation #35

Open
tsalo opened this issue Jun 24, 2021 · 1 comment · May be fixed by #36
Open

Support negative lags in RV calculation #35

tsalo opened this issue Jun 24, 2021 · 1 comment · May be fixed by #36
Labels
Enhancement New feature or request Good first issue Good for newcomers

Comments

@tsalo
Copy link
Member

tsalo commented Jun 24, 2021

Detailed Description

Currently, only positive lags are supported in RV calculation:

phys2denoise/phys2denoise/metrics/chest_belt.py

Line 155 in cfced3b

delays = [abs(int(lag * samplerate)) for lag in lags]

However, apply_lags() supports negative lags just fine.

Context / Motivation

I require this for an analysis, and there is no real cost. In fact, as it is implemented, it could be confusing for users.

Possible Implementation

I think it's pretty straightforward to fix:

    delays = [int(lag * samplerate) for lag in lags]
@tsalo tsalo added the Enhancement New feature or request label Jun 24, 2021
@smoia
Copy link
Member

smoia commented Jun 27, 2021

We can express the breaking change in the release description, if that's what worries you, but otherwise I would drop that abs() too!

@smoia smoia added the Good first issue Good for newcomers label Jun 27, 2021
@tsalo tsalo linked a pull request Jun 28, 2021 that will close this issue
Open
18 tasks
@rgbayrak rgbayrak moved this to To Do in phys2denoise Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement New feature or request Good first issue Good for newcomers
Projects
phys2denoise
Status: To Do
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix lag application for negative lags tsalo/phys2denoise
2 participants
@tsalo @smoia