-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add auto-author and auto-label to github workflow #52
Conversation
@smoia ready to review but CircleCI not happy |
Does someone who has CircleCI access re-run the style_check pipeline? On #54 style_check can run normally (the repo gets ssh cloned normally) We need to check if the current error is just random, because as it seems the circle ci configuration and keys to clone the phys2denoise repository are correct. |
thanks @maestroque - I tried to re-run but these are the options I have (most are greyed out) I wonder if I make a push to this branch it will trigger a re-run? |
Same options for me, I think you need to have admin access in circleci to re-run. A new push should trigger a re-run though hopefully. Another thing that could have gone wrong would be that the workflow ssh keys are incorrect, however @smoia's recent pushes in master did manage to clone the repo with ssh in the pipeline, but the tests still failed due to outdated unit tests. These are fixed in #54 |
Now it seems that the errors are the same as in master branch |
ok thanks @maestroque - should I merge for now? |
OK this is not fun. You can merge despite issues cause your changes are not affecting or are affected by the CI failures. The CI failures are related to numpy's versions and the numpy 2.0 release. I do not know how to deal with this issue - the closest thing I saw is this PR: MIPLabCH/nigsp#89 @msheltienne, could you help us with the numpy 2.0 incompatibility? |
@smoia could you open an issue to track this incompatibility? |
Closes #51
Proposed Changes
Change Type
bugfix
(+0.0.1)minor
(+0.1.0)major
(+1.0.0)refactoring
(no version update)test
(no version update)infrastructure
(no version update)documentation
(no version update)other
Checklist before review