Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto-author and auto-label to github workflow #52

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Conversation

RayStick
Copy link
Member

@RayStick RayStick commented Apr 24, 2024

Closes #51

Proposed Changes

  • The same as this PR for phys2bids but implemented for this repo
  • All I did was change the directory locations in the .github/labeler.yml file, otherwise the files are the same as the phys2bids files

Change Type

  • bugfix (+0.0.1)
  • minor (+0.1.0)
  • major (+1.0.0)
  • refactoring (no version update)
  • test (no version update)
  • infrastructure (no version update)
  • documentation (no version update)
  • other

Checklist before review

  • I added everything I wanted to add to this PR.
  • [Code or tests only] I wrote/updated the necessary docstrings.
  • [Code or tests only] I ran and passed tests locally.
  • [Documentation only] I built the docs locally.
  • My contribution is harmonious with the rest of the code: I'm not introducing repetitions.
  • My code respects the adopted style, especially linting conventions.
  • The title of this PR is explanatory on its own, enough to be understood as part of a changelog.
  • I added or indicated the right labels.
  • I added information regarding the timeline of completion for this PR.
  • Please, comment on my PR while it's a draft and give me feedback on the development!

@RayStick RayStick added the Internal Changes affect the internal API. It doesn't increase the version, but produces a changelog label Apr 24, 2024
@RayStick RayStick requested a review from smoia April 24, 2024 15:25
@RayStick RayStick self-assigned this Apr 24, 2024
@RayStick RayStick marked this pull request as ready for review April 24, 2024 15:53
@RayStick
Copy link
Member Author

@smoia ready to review but CircleCI not happy

@maestroque
Copy link
Contributor

Does someone who has CircleCI access re-run the style_check pipeline? On #54 style_check can run normally (the repo gets ssh cloned normally)

We need to check if the current error is just random, because as it seems the circle ci configuration and keys to clone the phys2denoise repository are correct.

@RayStick @smoia

@RayStick
Copy link
Member Author

RayStick commented Jul 12, 2024

thanks @maestroque - I tried to re-run but these are the options I have (most are greyed out)
Screenshot 2024-07-12 at 15 13 42

I wonder if I make a push to this branch it will trigger a re-run?

@maestroque
Copy link
Contributor

Same options for me, I think you need to have admin access in circleci to re-run. A new push should trigger a re-run though hopefully.

Another thing that could have gone wrong would be that the workflow ssh keys are incorrect, however @smoia's recent pushes in master did manage to clone the repo with ssh in the pipeline, but the tests still failed due to outdated unit tests. These are fixed in #54
@RayStick

@maestroque
Copy link
Contributor

Now it seems that the errors are the same as in master branch

@maestroque maestroque self-requested a review July 16, 2024 11:12
@RayStick
Copy link
Member Author

ok thanks @maestroque - should I merge for now?

@smoia
Copy link
Member

smoia commented Jul 16, 2024

OK this is not fun. You can merge despite issues cause your changes are not affecting or are affected by the CI failures.

The CI failures are related to numpy's versions and the numpy 2.0 release.

I do not know how to deal with this issue - the closest thing I saw is this PR: MIPLabCH/nigsp#89

@msheltienne, could you help us with the numpy 2.0 incompatibility?

@RayStick RayStick merged commit 8979423 into master Jul 16, 2024
2 of 4 checks passed
@RayStick RayStick deleted the add-workflows branch July 16, 2024 12:27
@maestroque
Copy link
Contributor

@smoia could you open an issue to track this incompatibility?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal Changes affect the internal API. It doesn't increase the version, but produces a changelog
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Implement auto-author-assign and auto-label workflows
3 participants