From b033a18a2429c86f8fb03b942db0ccfbb0be50d8 Mon Sep 17 00:00:00 2001 From: Jeff Miller Date: Mon, 1 Apr 2024 16:07:03 -0700 Subject: [PATCH] Remove obsolete "version" value from example docker-compose.yml in README.md and from .yml files in examples since "Compose doesn't use version to select an exact schema to validate the Compose file, but prefers the most recent schema when it's implemented." See: https://github.com/compose-spec/compose-spec/blob/master/04-version-and-name.md Signed-off-by: Jeff Miller <36978574+lemondjeff@users.noreply.github.com> --- README.md | 2 -- examples/docker-compose-caddy-proxy.yml | 2 -- examples/docker-compose-nginx-proxy.yml | 2 -- examples/docker-compose.yml.example | 2 -- 4 files changed, 8 deletions(-) diff --git a/README.md b/README.md index a194e955e..fce330012 100644 --- a/README.md +++ b/README.md @@ -25,8 +25,6 @@ [Docker-compose](https://docs.docker.com/compose/install/) example: ```yaml -version: "3" - # More info at https://github.com/pi-hole/docker-pi-hole/ and https://docs.pi-hole.net/ services: pihole: diff --git a/examples/docker-compose-caddy-proxy.yml b/examples/docker-compose-caddy-proxy.yml index 99d54d755..7ff96b30c 100644 --- a/examples/docker-compose-caddy-proxy.yml +++ b/examples/docker-compose-caddy-proxy.yml @@ -1,5 +1,3 @@ -version: "3" - services: # Caddy example derived from Caddy's own example at https://hub.docker.com/_/caddy diff --git a/examples/docker-compose-nginx-proxy.yml b/examples/docker-compose-nginx-proxy.yml index a08ed6c27..04b74c6d7 100644 --- a/examples/docker-compose-nginx-proxy.yml +++ b/examples/docker-compose-nginx-proxy.yml @@ -1,5 +1,3 @@ -version: "3" - # https://github.com/pi-hole/docker-pi-hole/blob/master/README.md services: diff --git a/examples/docker-compose.yml.example b/examples/docker-compose.yml.example index f52e18419..3d3e55129 100644 --- a/examples/docker-compose.yml.example +++ b/examples/docker-compose.yml.example @@ -1,5 +1,3 @@ -version: "3" - # https://github.com/pi-hole/docker-pi-hole/blob/master/README.md services: