feat: Added snippet preview #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VishalPawar1010
requested review from
shivay-at-pieces,
Arindam-at-Pieces and
mason-at-pieces
as code owners
Screen.Recording.2024-07-23.at.10.37.21.AM.mov |
shivay-at-pieces
suggested changes
Jul 23, 2024
There was a problem hiding this comment.
Hey @VishalPawar1010 do you mind having a look at the behavior for snippet preview. it appears to be not working correctly
|
Sure @shivay-at-pieces , |
VishalPawar1010
changed the title
shivay-at-pieces
suggested changes
Jul 25, 2024
|
Did you tried clean install and deploy? |
VishalPawar1010
force-pushed
the
#78-Show-Snippet-Preview-When-Selected
branch
from
199e145
to
dbe5a24
Compare
shivay-at-pieces
approved these changes
Jul 25, 2024
|
This one looks good to me, Just check my comment on #138 and after fixing that we can merge this. |
Arindam-at-Pieces
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #78
Note: Commented-out/removed snippet id shown in snippet card, as preview button was shown outside snippet card sometimes due to css issue. We can show id and other info in snippet preview and keep most important details on snippet card.
Test video: https://www.awesomescreenshot.com/video/29789678?key=e83d9b5f7673ac595c2d52dce993ca75