Update Button.tsx #65
Conversation
Creating the new main button style
There was a problem hiding this comment.
Hi @pythonistical this is a TypeScript file and you can't use html code directly here. You need to change the entire code to be having tsx notation.
|
@shivay-at-pieces actually I don't understand typescript, how about renaming the file to .htm or .css ? |
|
Hey @pythonistical unfortunately we can't replace a file like this. It has to follow the structure being followed throughout the rest of the codebase. I will recommend if you can spend some time learning TypeScript and in the meanwhile explore some of the other issues. This is a good starting point: https://www.typescriptlang.org/docs/handbook/intro.html Till then we can close this PR if it is alright @jordan-pieces. |
|
@pythonistical @shivay-at-pieces going to close this for now, but if we have more need for specific topics like this maybe we can put together some short learning that will help you (and others) in learning and contributing to this repository and other projects in the OSP 👍 lets setup a discussion around this if we want to take this further for now :) but i will be closing this PR |
Creating the new main button style at button.tsx
Description
This PR fixes #42