-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Process runs in background after closing window #43
Comments
Thanks, @foguetes
I wonder if there's something I should improve in src/electron-main.js? on a mac there is this /src/electron-main.js#L173-L179 (which is from electron's docs Writing Your First Electron App) but I don't see anything specific for Windows? or whether it is by design, eg the main process is always running, until you close the app. The render process, the one that shows you the window (and that there can be multiple of) can be opened and closed but closing a window doesn't close the app, coz the main process is still running, until the app is closed, if that makes sense? If I got this right, more in this in electron's docs Electron Application Architecture
I was also looking at electron's new version 8 and the Deprecation of remote Module (Starting in Electron 9) I suspect some of the use of In any case it needs refactoring to change it as explained in this comment electron/electron#21408 (comment) And just to confirm, we are talking about autoEdit3(autoedit.io) (and not autoEdit2 - opennewslabs.github.io/autoEdit_2 ) |
Try this release 1.2.6 if you get a chance, curious to see if startup time improves. ( some notes here on the changes made, removing remote in favor of ipc communication ) |
The problem persists in version 3-1.2.12 I open the app but the app windows takes several minutes to show up. When I try to open the developer console I get this error: |
Thanks @foguetes |
Altho I think it could be a bug in the menu /src/make-menu-template.js#L119 where it assumes there is a Could you open the inspector / console using keyboard shortcuts? cmd + alt + i on Mac, so on PC should be Windows key + alt + i? |
Hello Pietro, I have been looking at the different .js files loaded to see if one can have a conflicting line 13. switch.js, Lifecycle.js, HashRouter.js, BrowserRouter.js and withRouter.js all seem to have code related to React on line 13. If there is any other way I can help you solve the issue let me know! I should also mention that my comment was regarding both issues: background processes lingering after closing the app and the error on Help > Advanced - Developer Console. |
|
I am using a Windows 10 machine.
When I close autoedit I see the process is still running in the background using Task Manager.
If I try to open autoedit again the app window takes a very long time to show up, although the process is still running, as I said.
System specs as follows:
The text was updated successfully, but these errors were encountered: