Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process runs in background after closing window #43

Closed
foguetes opened this issue May 15, 2020 · 7 comments
Closed

Process runs in background after closing window #43

foguetes opened this issue May 15, 2020 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@foguetes
Copy link

I am using a Windows 10 machine.
When I close autoedit I see the process is still running in the background using Task Manager.
If I try to open autoedit again the app window takes a very long time to show up, although the process is still running, as I said.

System specs as follows:

OS Name	Microsoft Windows 10 Pro
Version	10.0.18362 Build 18362
Other OS Description 	Not Available
OS Manufacturer	Microsoft Corporation
System Name	DESKTOP-ISJR7QS
System Manufacturer	Alienware
System Model	Alienware Area-51 R5
System Type	x64-based PC
System SKU	836
Processor	Intel(R) Core(TM) i9-7940X CPU @ 3.10GHz, 3096 Mhz, 14 Core(s), 28 Logical Processor(s)
BIOS Version/Date	Alienware 2.0.3, 27.05.2019
SMBIOS Version	3.0
Embedded Controller Version	17.09
BIOS Mode	UEFI
BaseBoard Manufacturer	Alienware
BaseBoard Product	0N4R4N
BaseBoard Version	A00
Platform Role	Desktop
Secure Boot State	On
PCR7 Configuration	Elevation Required to View
Windows Directory	C:\WINDOWS
System Directory	C:\WINDOWS\system32
Boot Device	\Device\HarddiskVolume8
Locale	United States
Hardware Abstraction Layer	Version = "10.0.18362.752"
@foguetes foguetes added the bug Something isn't working label May 15, 2020
@pietrop
Copy link
Owner

pietrop commented May 15, 2020

Thanks, @foguetes

close autoedit I see the process is still running in the background

I wonder if there's something I should improve in src/electron-main.js?

on a mac there is this /src/electron-main.js#L173-L179 (which is from electron's docs Writing Your First Electron App) but I don't see anything specific for Windows?

or whether it is by design, eg the main process is always running, until you close the app. The render process, the one that shows you the window (and that there can be multiple of) can be opened and closed but closing a window doesn't close the app, coz the main process is still running, until the app is closed, if that makes sense? If I got this right, more in this in electron's docs Electron Application Architecture


the app window takes a very long time to show up

I was also looking at electron's new version 8 and the Deprecation of remote Module (Starting in Electron 9)

I suspect some of the use of remote module, might be causing the slow startup time, but not 100% sure.

In any case it needs refactoring to change it as explained in this comment electron/electron#21408 (comment)

And just to confirm, we are talking about autoEdit3(autoedit.io) (and not autoEdit2 - opennewslabs.github.io/autoEdit_2 )

@pietrop
Copy link
Owner

pietrop commented May 16, 2020

Try this release 1.2.6 if you get a chance, curious to see if startup time improves.

( some notes here on the changes made, removing remote in favor of ipc communication )

@foguetes
Copy link
Author

foguetes commented Jun 2, 2020

The problem persists in version 3-1.2.12
.

I open the app but the app windows takes several minutes to show up.

When I try to open the developer console I get this error:

image

@pietrop
Copy link
Owner

pietrop commented Jun 2, 2020

Thanks @foguetes
What’s the full path of the C:\... not the username but where there are the ... before the 13. Curious to see if it points to a specific file/module?

@pietrop
Copy link
Owner

pietrop commented Jun 2, 2020

Altho I think it could be a bug in the menu

/src/make-menu-template.js#L119 where it assumes there is a win object that it’s not in scope.

Could you open the inspector / console using keyboard shortcuts?

cmd + alt + i

on Mac, so on PC should be

Windows key + alt + i?

@sqr
Copy link

sqr commented Jun 4, 2020

Hello Pietro,
I am also facing this issue in Windows 10.
I have tried looking for the full path for the error but can't seem to find it, as I get no JS errors on the console.

I have been looking at the different .js files loaded to see if one can have a conflicting line 13.

switch.js, Lifecycle.js, HashRouter.js, BrowserRouter.js and withRouter.js all seem to have code related to React on line 13.

If there is any other way I can help you solve the issue let me know!

I should also mention that my comment was regarding both issues: background processes lingering after closing the app and the error on Help > Advanced - Developer Console.

@pietrop
Copy link
Owner

pietrop commented Jun 9, 2020

win error

ok removing the win object mentioned here #43 (comment) and releasing new version1.2.14

slow startup time

continuing the conversation around performance issues in windows as part of this other issue #44

background process

As I think the background process is default behaviour for electron, eg if you close a window, the app is still running until you close the app. if that makes sense?

but if that is not the case, feel free to re-open this issue.

@pietrop pietrop closed this as completed Jun 9, 2020
pietrop pushed a commit that referenced this issue Jun 9, 2020
added notice about original media, added Malay and Turkish language for speechmatics. removed #43 window bug. fixed search transcript list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants