New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecating func Monitor() interface to use go context to be more idiomatic #20

Open

pilebones opened this issue Jan 29, 2021 · 0 comments

Owner

pilebones commented Jan 29, 2021

https://github.com/pilebones/go-udev/blob/master/netlink/conn.go#L126

Change historical interface

func (c *UEventConn) Monitor(queue chan UEvent, errs chan error, matcher Matcher) chan struct{} {

By something like that:

func (c *UEventConn) Monitor(ctx context.Context, queue chan UEvent, errs chan error, matcher Matcher) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment