Skip to content

Commit ee6f809

Browse files
committed
refactor: remove getHeaderNames() polyfill and refactor clearHeaders()
`ServerResponse.getHeaderNames()` is available since Node v7.7.0
1 parent 44abc4d commit ee6f809

2 files changed

Lines changed: 3 additions & 18 deletions

File tree

‎HISTORY.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ unreleased
44
* deps:
55
* `fresh@^2.0.0`
66
* removed `destroy`
7+
* remove `getHeaderNames()` polyfill and refactor `clearHeaders()`
78

89
1.1.0 / 2024-09-10
910
==================

‎index.js‎

Lines changed: 2 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -775,10 +775,8 @@ SendStream.prototype.setHeader = function setHeader (path, stat) {
775775
*/
776776

777777
function clearHeaders (res) {
778-
var headers = getHeaderNames(res)
779-
780-
for (var i = 0; i < headers.length; i++) {
781-
res.removeHeader(headers[i])
778+
for (const header of res.getHeaderNames()) {
779+
res.removeHeader(header)
782780
}
783781
}
784782

@@ -886,20 +884,6 @@ function decode (path) {
886884
}
887885
}
888886

889-
/**
890-
* Get the header names on a response.
891-
*
892-
* @param {object} res
893-
* @returns {array[string]}
894-
* @private
895-
*/
896-
897-
function getHeaderNames (res) {
898-
return typeof res.getHeaderNames !== 'function'
899-
? Object.keys(res._headers || {})
900-
: res.getHeaderNames()
901-
}
902-
903887
/**
904888
* Determine if emitter has listeners of a given type.
905889
*

0 commit comments

Comments
 (0)