Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing Additional Values to pimcore_admin_dataobject_dataobject_add #758

Open
cancan101 opened this issue Nov 20, 2024 · 1 comment
Open

Comments

@cancan101
Copy link
Contributor

There is no way to pass additional values to be set on a new Object when calling pimcore_admin_dataobject_dataobject_add:

$object = $modelFactory->build($className);
$object->setOmitMandatoryCheck(true); // allow to save the object although there are mandatory fields
$classId = $request->request->get('classId');
if ($request->get('variantViaTree')) {
$parentId = $request->request->getInt('parentId');
$parent = DataObject\Concrete::getById($parentId);
$classId = $parent->getClass()->getId();
}
$object->setClassId($classId);
$object->setClassName($request->request->get('className'));
$object->setParentId($request->request->getInt('parentId'));
$object->setKey($request->request->get('key'));
$object->setCreationDate(time());
$object->setUserOwner($this->getAdminUser()->getId());
$object->setUserModification($this->getAdminUser()->getId());
$object->setPublished(false);

This means that if we want to extend the create form on the front end UI (e.g. in manyToManyObjectRelation) to capture additional fields, we would need to copy and paste the entire route.

const panelFcItems = [
this.parentField
];
if(pimcore.helpers.hasSearchImplementation()) {
this.parentChooseButton = new Ext.Button({
labelStyle: 'padding-left: 10px;',
iconCls: 'pimcore_icon_search',
handler: this.openParentSearchEditor.bind(this)
});
panelFcItems.push(this.parentChooseButton);
}

Copy link

Thanks a lot for reporting the issue. We did not consider the issue as "Pimcore:Priority", "Pimcore:ToDo" or "Pimcore:Backlog", so we're not going to work on that anytime soon. Please create a pull request to fix the issue if this is a bug report. We'll then review it as quickly as possible. If you're interested in contributing a feature, please contact us first here before creating a pull request. We'll then decide whether we'd accept it or not. Thanks for your understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant