Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] downloadImageThumbnailAction calling BinaryFileResponse with null #769

Open
cancan101 opened this issue Nov 26, 2024 · 1 comment
Open

Comments

@cancan101
Copy link
Contributor

Not sure when this happens, but downloadImageThumbnailAction sometimes calls $response = new BinaryFileResponse($thumbnailFile); with null:

Symfony\Component\HttpFoundation\BinaryFileResponse::__construct(): Argument #1 ($file) must be of type SplFileInfo|string, null given, called in /var/www/mdm/vendor/pimcore/admin-ui-classic-bundle/src/Controller/Admin/Asset/AssetController.php on line 1123

Image

I assume there is some issue with the thumbnail generation but ideally would not raise an uncaught error.

Copy link

Thanks a lot for reporting the issue. We did not consider the issue as "Pimcore:Priority", "Pimcore:ToDo" or "Pimcore:Backlog", so we're not going to work on that anytime soon. Please create a pull request to fix the issue if this is a bug report. We'll then review it as quickly as possible. If you're interested in contributing a feature, please contact us first here before creating a pull request. We'll then decide whether we'd accept it or not. Thanks for your understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant