Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search Box is not Mobile Friendly / Accessible #830

Open
cancan101 opened this issue Feb 10, 2025 · 3 comments
Open

Search Box is not Mobile Friendly / Accessible #830

cancan101 opened this issue Feb 10, 2025 · 3 comments

Comments

@cancan101
Copy link
Contributor

this.searchField = new Ext.form.TextField(
{
name: "query",
width: 200,
hideLabel: true,
enableKeyEvents: true,
value: this.searchFilter,
triggers: {
search: {
weight: 1,
cls: 'x-form-search-trigger',
scope: 'this',
handler: function (field, trigger, e) {
this.searchQuery(field);
}.bind(this)
}
},
listeners: {
"change": function () {
this.saveColumnConfigButton.show();
}.bind(this),
"keydown": function (field, key) {
if (key.getKey() == key.ENTER) {
this.searchQuery(field);
}
}.bind(this)
}
}
);

should use some combination of:

Otherwise the OS may not show an enter key on mobile.

@fashxp
Copy link
Member

fashxp commented Feb 10, 2025

would you consider the rest of the admin-ui-classic as mobile friendly? 🤔 😄

@cancan101
Copy link
Contributor Author

not particularly, but I did notice this even using "Desktop" mode in browser. While the search icon can be clicked, that is non standard behavior.

From an accessibility (even non mobile) standpoint, some of the attributes above would be an improvement.

@cancan101 cancan101 changed the title Search Box is not Mobile Friendly Search Box is not Mobile Friendly / Accessible Feb 10, 2025
@fashxp
Copy link
Member

fashxp commented Feb 10, 2025

not sure we will invest a lot in that regards into admin-ui-classic anymore ... our focus is on studio-ui.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants