Skip to content

Commit 7416eb4

Browse files
authored
Merge pull request #80 from pin/fd-leak-fix-fix
Fix sender FD leak fix
2 parents b0f7c38 + e77a42b commit 7416eb4

File tree

1 file changed

+12
-10
lines changed

1 file changed

+12
-10
lines changed

sender.go

+12-10
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,10 @@ func (s *sender) ReadFrom(r io.Reader) (n int64, err error) {
6868
r = netascii.ToReader(r)
6969
}
7070
defer func() {
71-
s.conn.close()
72-
s.conn = nil
71+
if s.conn != nil {
72+
s.conn.close()
73+
s.conn = nil
74+
}
7375
}()
7476
if s.opts != nil {
7577
// check that tsize is set
@@ -260,15 +262,15 @@ func (s *sender) sendDatagram(l int) (*net.UDPAddr, error) {
260262

261263
func (s *sender) buildTransferStats() TransferStats {
262264
return TransferStats{
263-
RemoteAddr: s.addr.IP,
264-
Filename: s.filename,
265-
Tid: s.tid,
265+
RemoteAddr: s.addr.IP,
266+
Filename: s.filename,
267+
Tid: s.tid,
266268
SenderAnticipateEnabled: s.sendA.enabled,
267-
Mode: s.mode,
268-
Opts: s.opts,
269-
Duration: time.Now().Sub(s.startTime),
270-
DatagramsSent: s.datagramsSent,
271-
DatagramsAcked: s.datagramsAcked,
269+
Mode: s.mode,
270+
Opts: s.opts,
271+
Duration: time.Now().Sub(s.startTime),
272+
DatagramsSent: s.datagramsSent,
273+
DatagramsAcked: s.datagramsAcked,
272274
}
273275
}
274276

0 commit comments

Comments
 (0)