Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light alternative #24

Open
Nargonath opened this issue Mar 31, 2021 · 10 comments
Open

Light alternative #24

Nargonath opened this issue Mar 31, 2021 · 10 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Nargonath
Copy link

Thanks for this awesome Vim theme. 🙏

I find myself working in bright environment during the day and the current theme is hard to see properly when you have some light shining on your screen. Would you accept a light version of this theme? As Solarized has for example. I've never worked with Vim theme yet so I have no clue how such light version could be distributed or setup but if that's a contribution you'd accept I'd be happy to work on it and contribute.

Thank you.

@pineapplegiant
Copy link
Owner

pineapplegiant commented Mar 31, 2021

Great suggestion. I struggle with this at work as well. I will be working on this next along with a lower contrast variant.

Perhaps I can get feedback along the way. I need to setup tickets system so people see what I’m working on.

@Nargonath
Copy link
Author

Perhaps GitHub's projects tab would be the right tool for that.

I'm not sure I understood you correctly, could I contribute on that or do you prefer to take care of it?

@pineapplegiant
Copy link
Owner

Yeah I’ll set that up. My apologies I wasn’t very clear.

Yeah I’d love help if you want to take on this task, but I can also take care of it too. These things are very subjective so I’ll be very picky on colors, but can help you along the way if you’d like 👍

@Nargonath
Copy link
Author

No worries. I don't want to waste your time either. You'll be more efficient than I'd be anyway. Let's say that if you're already working on something and don't have time to look into it I can start on my end however if you have nothing on your plate right now and you want to get on it I'll get out of the way. How does it sound? Are you currently on something?

@jinh0 jinh0 added the enhancement New feature or request label Apr 19, 2021
@pineapplegiant
Copy link
Owner

pineapplegiant commented Apr 19, 2021

@Nargonath sorry I took so long to respond.
Yes I would love some help on this. I'm working on bugfixes and trying to improve the general theme in other ways and to setup releases. I'm not the biggest fan of light themes, but if I were to give you some creative vision I would prefer the background not to be absolutely white like maybe this rose-pine-theme, or horizon-theme where they have slight variations in the background than pure white. Maybe a light pink? I'm not entirely sure, but I can give you feedback along the way.

@Nargonath
Copy link
Author

No worries @pineapplegiant, I manage some Open Source projects myself as well, I know how it is. 😉

I don't use light color theme most of the time either. I just use them when my work environment is too bright.

That's definitely what I had in mind. I thought of solarized light as an example too. I'll try to work as much as possible with your current color palette. I'll report back when I have something to show you. 👍

@jinh0 jinh0 pinned this issue Apr 19, 2021
@jinh0 jinh0 added the help wanted Extra attention is needed label May 5, 2021
@Nargonath
Copy link
Author

Nargonath commented May 23, 2021

I started to dig in this issue. That's the first time I work on a Vim colorscheme so I might be wrong but it seems to me that in order to easily switch the colors between the light/dark background we need to rewrite most of the colors/spaceduck.vim file. From what I grasped I think we need to:

  • Extract all the colors codes into variables (dictionary seems the best): that way we can easily change the color used in guibg|ctermbg.
  • Rewrite the hi calls to a custom function call so we can easily override the underlying hi calls to handle specific case and concatenate the colors from the palette we made in the previous step.

I looked to other schemes for inspiration. Here are some examples:

What do you think @pineapplegiant @jinh0 ? Did you already have in mind a way you wanted to do that?

I'll try to spin up an example of how I suggest we can proceed and show you ASAP so we can better debate against it.

@refmathew
Copy link

Hello. I'm a light theme user, and been waiting for the light theme so I could finally switch from my current theme. Might I know what the status of the light theme is?

@pineapplegiant
Copy link
Owner

Hey @refmathew, I haven't been working on spaceduck all too much 😞 so I can't confidently say when to expect the theme to be finished (definitely this year). I still do intend to finish the light theme palette and the middle/lighter theme variant as well. My goal is to have the theme in a place like catpuccin has their theme laid out.

When I do have it out, your feedback would be really helpful, since light theme users are in the minority from my experience.

One thing to note, is I do intend for the future of the theme to be in lua, and I'll likely archive this repo hopefully after I get these issues taken care of:

https://github.com/spaceduck-theme/nvim

@Nargonath
Copy link
Author

I'm pretty busy as well on my side. I ported the theme to Lua but I don't have the time to work on the light theme for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants