Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider tweaking the comments color #34

Closed
fdidron opened this issue May 19, 2021 · 4 comments
Closed

Consider tweaking the comments color #34

fdidron opened this issue May 19, 2021 · 4 comments

Comments

@fdidron
Copy link

fdidron commented May 19, 2021

Hello,

I absolutely love this color theme. However one issue I have with it is the comments color is a bit too dark, making the comments hardly visible.

Tweaking the comments color to a slighlty brighter color goes a long way IMHO (window on the bottom contains the tweak)

comments

Now this is probably a matter of opinion :) Happy to make a PR if you think it is worth it

@pineapplegiant
Copy link
Owner

pineapplegiant commented May 19, 2021

Hey! Thanks for this. Yes you’re absolutely right. I’ve been super procrastinating on many things, but this one is a must. We have changed the comment color along with some other things on our dev branch!

Like instead of main try out dev and tell me what you think. I’m in the process of finalizing colors still so I’ll keep this open until I merge into main. If you’re using vim plug just switch the branch to “dev”.

@fdidron
Copy link
Author

fdidron commented May 20, 2021

@pineapplegiant Just tried the dev branch, that's perfect !

@Nargonath
Copy link

Thanks for raising this, it's been on my mind lately too. That's cool to see that you already took care of it @pineapplegiant . 💪

@jinh0 jinh0 pinned this issue May 26, 2021
@jinh0
Copy link
Collaborator

jinh0 commented May 26, 2021

For any future developers who have similar complaints of dark comment color or cursor line color, please use the dev branch of the colorscheme until version 0.1 is released to the main branch.

This can be done as follows using a plugin manager like vim-plug:

Plug 'pineapplegiant/spaceduck', { 'branch': 'dev' }

@jinh0 jinh0 closed this as completed May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants