Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split functions and returned sequence types in test/sequenceTools.js into separate files #160

Open
pineapplemachine opened this issue Sep 5, 2017 · 3 comments
Labels
effort: low The issue will probably take a single contributor no more than one day of work to resolve. meta: good first issue The issue is especially suitable for first-time contributors. priority: trivial The issue has very little impact on people using the software. type: polish The issue involves making existing functionality more usable.

Comments

@pineapplemachine
Copy link
Owner

Currently the file contains lots of things, like unknownLength/UnknownLengthSequence and makeUnidirectional/UnidirectionalSequence. These should each be moved into their own files inside the test directory and sequenceTools.js should be removed.

See #158 (comment)

To prevent existing code from breaking it will be necessary to also remove the sequenceTools import in higher.js and add an import for every file separated out in this way.

@pineapplemachine pineapplemachine added effort: low The issue will probably take a single contributor no more than one day of work to resolve. priority: trivial The issue has very little impact on people using the software. type: polish The issue involves making existing functionality more usable. labels Sep 5, 2017
@jpsullivan
Copy link
Collaborator

I actually don't think you'd have to remove the sequenceTools imports at all if you made it simply export each new file.

For example, after splitting it into separate files, this one would now look like...

export * as NonSlicingInput from './nonSlicing';
export * as BoundsUnknownSequence from './boundsUnknown';
...

Think will still let you import everything at once, and won't require any changes to your other files.

@pineapplemachine
Copy link
Owner Author

sequenceTools is only imported by one file, it would be cleaner for that one file to just import all the new ones instead.

@jpsullivan
Copy link
Collaborator

And here I was thinking it was used everywhere lol. Carry on!

@pineapplemachine pineapplemachine added the meta: good first issue The issue is especially suitable for first-time contributors. label Nov 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: low The issue will probably take a single contributor no more than one day of work to resolve. meta: good first issue The issue is especially suitable for first-time contributors. priority: trivial The issue has very little impact on people using the software. type: polish The issue involves making existing functionality more usable.
Projects
None yet
Development

No branches or pull requests

2 participants