Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make failed requests in Run phase progress more obvious / explicit #133

Open
daverigby opened this issue Jun 21, 2024 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@daverigby
Copy link
Collaborator

daverigby commented Jun 21, 2024

Requests are expected to succeed - if they fail then that's something which should be highlighted to users, but it's not particulary obvious right now - only shown in the failures column in a busy table:

2024-06-21T13:20:20 INFO     Completed Run phase, took 46.08s                                                                                                                                                                                                                                                                 
2024-06-21T13:20:23 INFO         Type     Name                                                                          # reqs      # fails |    Avg     Min     Max    Med |   req/s  failures/s                                                                                                                             2024-06-21T13:20:23 INFO         --------|----------------------------------------------------------------------------|-------|-------------|-------|-------|-------|-------|--------|-----------                                                                                                                             
2024-06-21T13:20:23 INFO         Search   mnist                                                                          10000    21(0.21%) |     79       8    1960     30 |  203.78        0.43                                                                                                                             
2024-06-21T13:20:23 INFO         --------|----------------------------------------------------------------------------|-------|-------------|-------|-------|-------|-------|--------|-----------                                                                                                                             
2024-06-21T13:20:23 INFO                  Aggregated                                                                     10000    21(0.21%) |     79       8    1960     30 |  203.78        0.43                                                                                                                             

Note the "# fails" column above.

Possible improvement idead:

  • We show request/s, but it would also be useful to show the failed count so far. This is expected to be zero, so highlighting non-zero is valuable.
  • Requests failing due to timeout (e.g. tenacity retry limit reached) are logged in vsb.log, but this isn't printed to the user. Consider if we should promote such messages to the console (might be too noisy, but could be worth it...)
@daverigby daverigby changed the title Include failed requests in Run phase progress status Make failed requests in Run phase progress more obvious / explicit Jun 21, 2024
@daverigby daverigby added the enhancement New feature or request label Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants