Skip to content

refine modify column #21110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ti-chi-bot merged 18 commits into from
Jan 13, 2026
Merged

refine modify column #21110

ti-chi-bot merged 18 commits into from
Jan 13, 2026

Conversation

@wjhuang2016
Copy link
Member

@wjhuang2016 wjhuang2016 commented Nov 24, 2025 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@wjhuang2016
init
3d748fc 
Signed-off-by: wjhuang2016 <[email protected]>
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 24, 2025
joechenrh
joechenrh reviewed Nov 25, 2025
View reviewed changes
@qiancai qiancai self-assigned this Nov 25, 2025
@qiancai qiancai added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 26, 2025
@qiancai
Copy link
Collaborator

qiancai commented Nov 26, 2025 •
edited
Loading

add the do-not-merge/hold label as the change in this PR won't be included in v8.5.4

qiancai
qiancai reviewed Nov 26, 2025
View reviewed changes
@qiancai qiancai added translation/doing This PR’s assignee is translating this PR. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. and removed missing-translation-status This PR does not have translation status info. labels Nov 26, 2025
@wjhuang2016 @joechenrh @qiancai
Apply suggestions from code review
72913a6 
Co-authored-by: Ruihao Chen <[email protected]>
Co-authored-by: Grace Cai <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 12, 2025
qiancai
qiancai reviewed Dec 12, 2025
View reviewed changes
qiancai
qiancai reviewed Dec 12, 2025
View reviewed changes
qiancai
qiancai reviewed Dec 12, 2025
View reviewed changes
qiancai
qiancai reviewed Dec 12, 2025
View reviewed changes
qiancai
qiancai reviewed Dec 12, 2025
View reviewed changes
qiancai
qiancai reviewed Dec 30, 2025
View reviewed changes
qiancai
qiancai reviewed Dec 30, 2025
View reviewed changes
qiancai
qiancai reviewed Dec 30, 2025
View reviewed changes
@qiancai qiancai mentioned this pull request Jan 6, 2026
Merged
14 tasks
github-actions bot added a commit to qiancai/docs that referenced this pull request Jan 6, 2026
@github-actions
Auto-sync: Update English docs from Chinese PR
0e2681e 
Synced from: pingcap/docs-cn#21110
Target PR: pingcap#22268
AI Provider: gemini

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@Oreoxmt Oreoxmt self-requested a review January 6, 2026 07:37
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 6, 2026
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 6, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-01-06 07:38:50.067673289 +0000 UTC m=+687885.885981711: ☑️ agreed by Oreoxmt.

@qiancai qiancai added the v9.0-beta.3 This PR/issue applies to TiDB v9.0-beta.3. label Jan 7, 2026
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 13, 2026

@joechenrh: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

qiancai
qiancai reviewed Jan 13, 2026
View reviewed changes
qiancai
qiancai reviewed Jan 13, 2026
View reviewed changes
qiancai
qiancai reviewed Jan 13, 2026
View reviewed changes
qiancai
qiancai reviewed Jan 13, 2026
View reviewed changes
@qiancai
Copy link
Collaborator

qiancai commented Jan 13, 2026

/approve

@qiancai qiancai added lgtm translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. translation/doing This PR’s assignee is translating this PR. labels Jan 13, 2026
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 13, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 13, 2026
@ti-chi-bot ti-chi-bot bot merged commit a6afb9c into pingcap:master Jan 13, 2026
7 checks passed
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 13, 2026

In response to a cherrypick label: new pull request created to branch release-8.5: #21276.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 13, 2026
Merged
14 tasks
ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Jan 13, 2026
@github-actions @ti-chi-bot
Auto-sync: Update English docs from Chinese PR
37158b3 
Synced from: pingcap/docs-cn#21110
Target PR: pingcap#22268
AI Provider: gemini

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 13, 2026
Merged
14 tasks
qiancai added a commit that referenced this pull request Jan 16, 2026
@ti-chi-bot @joechenrh
@qiancai @Oreoxmt @wjhuang2016
v8.5.5: refine modify column (#21110) (#21276)
95933f1 
Co-authored-by: Ruihao Chen <[email protected]>
Co-authored-by: Grace Cai <[email protected]>
Co-authored-by: Aolin <[email protected]>
Co-authored-by: wjhuang2016 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qiancai qiancai qiancai left review comments

@Frank945946 Frank945946 Frank945946 left review comments

@Oreoxmt Oreoxmt Oreoxmt approved these changes

+1 more reviewer

@joechenrh joechenrh joechenrh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@qiancai qiancai

Labels

approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v9.0-beta.3 This PR/issue applies to TiDB v9.0-beta.3.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@wjhuang2016 @qiancai @Oreoxmt @ti-chi-bot @joechenrh @Frank945946