-
Notifications
You must be signed in to change notification settings - Fork 706
tidbcloud/premium: add create private endpoint #21923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tidbcloud/premium: add create private endpoint #21923
Conversation
|
Hi @wildpcww. Thanks for your PR. I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Summary of ChangesHello @wildpcww, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces new documentation that guides users through the process of establishing secure and private connections to TiDB Cloud Premium instances via AWS PrivateLink. The new guide provides detailed, step-by-step instructions, covering prerequisites, endpoint creation, DNS configuration, and troubleshooting, ensuring users can effectively manage their network access to TiDB Cloud. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a new documentation page for connecting to a TiDB Cloud Premium instance via AWS PrivateLink. The changes are well-structured and mostly align with the documentation style guide. I've provided several suggestions to improve clarity, fix minor grammatical issues and typos, correct broken internal links, and ensure consistency. These changes will help make the document more polished and easier for users to follow.
tidb-cloud/premium/connect-to-premium-via-aws-private-endpoint.md
Outdated
Show resolved
Hide resolved
| - The private endpoint and the TiDB instance to be connected must be located in the same region. | ||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
/ok-to-test |
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Lilian Lee <[email protected]>
Co-authored-by: Lilian Lee <[email protected]>
Co-authored-by: Lilian Lee <[email protected]>
|
/cc @sdojjy |
Renamed the premium connection guide for AWS private endpoints and revised wording in the private endpoint setup documentation for improved clarity and consistency. Changes include role descriptions, port formatting, UI instructions, and troubleshooting steps.
Renamed 'connect-to-premium-via-aws-private-endpoint.md.md' to 'connect-to-premium-via-aws-private-endpoint.md' for consistency and to remove redundant file extension.
Updated references to 'TiDB Cloud Premium instance' in the AWS PrivateLink connection guide to use the '{{{ .premium }}}' template variable for improved maintainability and consistency.
tidb-cloud/premium/connect-to-premium-via-aws-private-endpoint.md
Outdated
Show resolved
Hide resolved
tidb-cloud/premium/connect-to-premium-via-aws-private-endpoint.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[LGTM Timeline notifier]Timeline:
|
|
@srstack: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
tidb-cloud/premium/connect-to-premium-via-aws-private-endpoint.md
Outdated
Show resolved
Hide resolved
tidb-cloud/premium/connect-to-premium-via-aws-private-endpoint.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lilin90 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
First-time contributors' checklist
What is changed, added or deleted? (Required)
Base on https://docs.pingcap.com/tidbcloud/set-up-private-endpoint-connections/
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?