Skip to content

Conversation

@wildpcww
Copy link
Collaborator

First-time contributors' checklist

What is changed, added or deleted? (Required)

Base on https://docs.pingcap.com/tidbcloud/set-up-private-endpoint-connections/

  1. changed Dedicated cluster-> Premium instance
  2. deleted project-level description

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. labels Oct 16, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 16, 2025

Hi @wildpcww. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added the needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. label Oct 16, 2025
@gemini-code-assist
Copy link

Summary of Changes

Hello @wildpcww, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces new documentation that guides users through the process of establishing secure and private connections to TiDB Cloud Premium instances via AWS PrivateLink. The new guide provides detailed, step-by-step instructions, covering prerequisites, endpoint creation, DNS configuration, and troubleshooting, ensuring users can effectively manage their network access to TiDB Cloud.

Highlights

  • New Documentation: Added a comprehensive guide on how to connect to TiDB Cloud Premium instances using AWS PrivateLink, ensuring secure and private network access.
  • Terminology Update: Updated product terminology within the documentation, specifically changing 'Dedicated cluster' to 'Premium instance' for consistency.
  • Content Refinement: Removed project-level descriptions to streamline the documentation and improve clarity.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 16, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new documentation page for connecting to a TiDB Cloud Premium instance via AWS PrivateLink. The changes are well-structured and mostly align with the documentation style guide. I've provided several suggestions to improve clarity, fix minor grammatical issues and typos, correct broken internal links, and ensure consistency. These changes will help make the document more polished and easier for users to follow.

- The private endpoint and the TiDB instance to be connected must be located in the same region.



Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Please remove this extra blank line to improve formatting.

wildpcww and others added 2 commits October 16, 2025 14:43
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@lilin90 lilin90 added for-cloud-release This PR is related to TiDB Cloud release. translation/no-need No need to translate this PR. labels Oct 16, 2025
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Oct 16, 2025
@lilin90
Copy link
Member

lilin90 commented Oct 16, 2025

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Oct 16, 2025
wildpcww and others added 4 commits October 16, 2025 17:56
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@lilin90 lilin90 self-assigned this Oct 20, 2025
lilin90 and others added 4 commits October 22, 2025 14:36
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@wildpcww
Copy link
Collaborator Author

wildpcww commented Oct 27, 2025

/cc @sdojjy

@ti-chi-bot ti-chi-bot bot requested a review from sdojjy October 27, 2025 08:12
Renamed the premium connection guide for AWS private endpoints and revised wording in the private endpoint setup documentation for improved clarity and consistency. Changes include role descriptions, port formatting, UI instructions, and troubleshooting steps.
Renamed 'connect-to-premium-via-aws-private-endpoint.md.md' to 'connect-to-premium-via-aws-private-endpoint.md' for consistency and to remove redundant file extension.
Updated references to 'TiDB Cloud Premium instance' in the AWS PrivateLink connection guide to use the '{{{ .premium }}}' template variable for improved maintainability and consistency.
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 27, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 27, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-10-27 08:40:05.577623689 +0000 UTC m=+1293111.654876259: ☑️ agreed by lilin90.

@lilin90 lilin90 requested a review from srstack October 28, 2025 02:58
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 28, 2025

@srstack: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lilin90 lilin90 removed the request for review from sdojjy October 28, 2025 06:15
@lilin90 lilin90 mentioned this pull request Oct 28, 2025
14 tasks
@lilin90 lilin90 added the lgtm label Oct 28, 2025
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilin90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Oct 29, 2025
@ti-chi-bot ti-chi-bot bot merged commit 9928691 into pingcap:release-8.5 Oct 29, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. for-cloud-release This PR is related to TiDB Cloud release. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. ok-to-test Indicates a PR is ready to be tested. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants