Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP]support multiple mysql hosts #1023

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[WIP]support multiple mysql hosts #1023

wants to merge 2 commits into from
+30 −4

Conversation

shonge
Copy link
Member

@shonge shonge commented Dec 8, 2020 •
edited
Loading

What problem does this PR solve?

resolved #1013

What is changed and how it works?

support mysql downstream
[syncer.to]
host = "192.168.0.1,192.168.0.2"

Randomly choose one of the hosts as downstream mysql host

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update the tidb-ansible repository
  • Need to be included in the release note

@shonge shonge changed the title support multiple mysql hosts [WIP]support multiple mysql hosts Dec 15, 2020
@ti-chi-bot
Copy link
Member

@shonge: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
first-time-contributor needs-rebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support to specify downstream host with multiple IPs
4 participants
@shonge @ti-chi-bot @CLAassistant @ti-srebot