Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bilateral synchronization: Write conflict could happen in update mark table #1022

Open
3pointer opened this issue Dec 3, 2020 · 1 comment

Comments

@3pointer
Copy link
Contributor

3pointer commented Dec 3, 2020

Bug Report

  1. What did you do?
    If possible, provide a recipe for reproducing the error.
    enable bilateral synchronization with two TiDB cluster.

  2. What did you expect to see?
    update mark table without conflict.

  3. What did you see instead?
    write conflict in TiDB log.

  4. Please provide the relate downstream type and version of drainer.
    (run drainer -V in terminal to get drainer's version)
    v4.0.2

@3pointer
Copy link
Contributor Author

3pointer commented Dec 3, 2020

we have workercount number of goroutine to singleExecRetry dmls. and each worker will get one certain id from addIndex, this usually works fine.

the problem is here, we might split dmls again in some worker. this could make write conflict due to some worker may get same id by addIndex.

I think the solution is we should bind the worker with id, no matter how much dmls it have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant