Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude tidb_binlog & other reserved database names out-of-box #905

Open
sokada1221 opened this issue Feb 19, 2020 · 3 comments
Open

Exclude tidb_binlog & other reserved database names out-of-box #905

sokada1221 opened this issue Feb 19, 2020 · 3 comments
Labels
feature-request This issue is a feature request

Comments

@sokada1221
Copy link

Feature Request

Is your feature request related to a problem? Please describe:

For the database migration that we're performing, we setup DM from Aurora to TiDB first. Then after the migration, we'll revert the replication to replicate from TiDB to Aurora using drainer.

As we switch the replication direction back and forth, we hit an issue where manual changes to tidb_binlog database propagate and break the replication.

Describe the feature you'd like:

In general, any reserved database names for TiDB tools should be excluded from replication pipeline out-of-box.

For instance, in addition to tidb_binlog, I can quickly think of the following:

  • dm_meta
  • sync_diff_inspector
  • tidb_loader

If we get a consensus on this, I think we can apply the same default rule to other replication tools too (e.g. DM).

Describe alternatives you've considered:

  • Manually add tidb_binlog to the ignore-schemas configuration

Teachability, Documentation, Adoption, Migration Strategy:

N/A

@sokada1221 sokada1221 added the feature-request This issue is a feature request label Feb 19, 2020
@july2993
Copy link
Contributor

SGTM @csuzhangxc @GregoryIan PTAL and maybe we should better use some common pattern name for such reserved database.

@csuzhangxc
Copy link
Member

How about choosing a schema for all TiDB tools as another system schema? But this may break the compatibility.

@july2993
Copy link
Contributor

How about choosing a schema for all TiDB tools as another system schema? But this may break the compatibility.

using some agreed name like tidb_tool should be good for the later tools(if we have), it's ok to keep the existing tools with the current names?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request This issue is a feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants