Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some reserved db for tools as ignore schema default. #913

Closed
wants to merge 1 commit into from
Closed

Add some reserved db for tools as ignore schema default. #913

wants to merge 1 commit into from

Conversation

july2993
Copy link
Contributor

What problem does this PR solve?

fix #905

this also helps the bi-replication deploy, we don't need to add the tidb_binlog mannually.
and using sync_diff will break the replication.

What is changed and how it works?

Add some reserved db for tools as ignore schema default.

Check List

Tests

Code changes

Side effects

  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

@IANTHEREAL
Copy link
Collaborator

@WangXiangUSTC should we ignore the schema like sync_diff_inspector?

@WangXiangUSTC
Copy link
Contributor

@WangXiangUSTC should we ignore the schema like sync_diff_inspector?

it saves the checkpoint infomation, should ignore it

@WangXiangUSTC
Copy link
Contributor

LGTM

zier-one
zier-one approved these changes May 12, 2020
View reviewed changes
Copy link
Contributor

@zier-one zier-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@july2993 july2993 closed this May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zier-one zier-one zier-one approved these changes

@IANTHEREAL IANTHEREAL Awaiting requested review from IANTHEREAL

@csuzhangxc csuzhangxc Awaiting requested review from csuzhangxc

Assignees
No one assigned
Labels
need-update-ansible needs-cherry-pick-release-3.0 status/LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exclude tidb_binlog & other reserved database names out-of-box
4 participants
@july2993 @IANTHEREAL @WangXiangUSTC @zier-one