Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drainer: reduce memory usage when restart #1030

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

drainer: reduce memory usage when restart #1030

wants to merge 12 commits into from
+202 −63

Conversation

you06
Copy link
Contributor

@you06 you06 commented Dec 29, 2020 •
edited
Loading

What problem does this PR solve?

close #978

When drainer restart, it'll load all DDL history from TiDB cluster, this will cause a large memory usage.

What is changed and how it works?

This PR change the DDL history load strategy, load only recently DDLs into drainer, for the stale DDLs, load from a snapshot schema.

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Release note

  • Reduce memory usage when drainer restart

@sre-bot
Copy link

sre-bot commented Dec 29, 2020

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

you06 and others added 11 commits December 29, 2020 15:34
@you06
reduce memory usage in drainer startup
72fa15a 
Signed-off-by: you06 <[email protected]>
@you06
get snapshot from store when load schema
30f0f08 
Signed-off-by: you06 <[email protected]>
@you06
add restore log
d722bfb 
Signed-off-by: you06 <[email protected]>
@you06
add debug log
d80a487 
Signed-off-by: you06 <[email protected]>
@you06
add more debug log
3b99898 
Signed-off-by: you06 <[email protected]>
@you06
log error when load history meta failed
a7e45de 
Signed-off-by: you06 <[email protected]>
@you06
add detail log
5f607c7 
Signed-off-by: you06 <[email protected]>
@you06
add more debug log
2e3e0d0 
Signed-off-by: you06 <[email protected]>
@you06
add more debug log
62133d6 
Signed-off-by: you06 <[email protected]>
@you06
resolve OOM when restart
17be2c4
@you06
use latest tidb
9483ff8 
Signed-off-by: you06 <[email protected]>
@you06 you06 force-pushed the reduce-memory-usage branch from e68b624 to 9483ff8 Compare December 29, 2020 07:56
@sre-bot
Copy link

sre-bot commented Dec 29, 2020

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

@you06
remove unused code
e6bbe2f 
Signed-off-by: you06 <[email protected]>
@you06
Copy link
Contributor Author

you06 commented Dec 29, 2020

This is a draft implementation.

Because the relationship between job.BinlogInfo.SchemaVersion and job.ID is unknowable, drainer still to load all DDL history to check whether it's schema version is newer than current binlog, the most work we do makes non sense, and it'll cost a long time loading history.

@you06
Copy link
Contributor Author

you06 commented Dec 29, 2020

/run-all-tests

@you06
Copy link
Contributor Author

you06 commented Dec 29, 2020

/run-integration-test

@you06
Copy link
Contributor Author

you06 commented Dec 29, 2020

/run-all-tests

@ti-chi-bot
Copy link
Member

@you06: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
first-time-contributor needs-rebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Please help reduce use system memory when drainer startup
5 participants
@you06 @sre-bot @ti-chi-bot @CLAassistant @ti-srebot