Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support batch serialize/deserialize method for Column #9756

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

support batch serialize/deserialize method for Column #9756

wants to merge 18 commits into from
+1,897 −340

Conversation

guo-shaoge
Copy link
Contributor

@guo-shaoge guo-shaoge commented Jan 1, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: close #9761

Problem Summary: #9553 add serialize/deserialize interface by column-wise, but it didn't handle collator for ColumnString and real copy format for ColumnDecimal([sign, limb_count, limb_data])

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@guo-shaoge
basically done
e4b57c8 
Signed-off-by: guo-shaoge <[email protected]>
@guo-shaoge
fix compilation
1574825 
Signed-off-by: guo-shaoge <[email protected]>
@guo-shaoge
fmt
4203af0 
Signed-off-by: guo-shaoge <[email protected]>
@guo-shaoge
compile && nt_optimization
29021b2 
Signed-off-by: guo-shaoge <[email protected]>
@guo-shaoge
unit test
a3cd638 
Signed-off-by: guo-shaoge <[email protected]>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 1, 2025
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 1, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from guo-shaoge, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@guo-shaoge
refine
d155847 
Signed-off-by: guo-shaoge <[email protected]>
@guo-shaoge
fix
d3b0300 
Signed-off-by: guo-shaoge <[email protected]>
@guo-shaoge guo-shaoge requested a review from gengliqi January 2, 2025 09:33
@guo-shaoge
test ci impl
c07d13a 
Signed-off-by: guo-shaoge <[email protected]>
@guo-shaoge
Revert "test ci impl"
086b630 
This reverts commit c07d13a.
@guo-shaoge
Revert "test new impl"
db8d490 
This reverts commit abd55ac.
@guo-shaoge
change name
84ee65b 
Signed-off-by: guo-shaoge <[email protected]>
@guo-shaoge
is_fast -> ensure_unique
3800d0f 
Signed-off-by: guo-shaoge <[email protected]>
@guo-shaoge
batchSerializeImpl -> serializeToPosImpl
a6fac1f 
Signed-off-by: guo-shaoge <[email protected]>
@guo-shaoge
ci
19982d3 
Signed-off-by: guo-shaoge <[email protected]>
@guo-shaoge
Copy link
Contributor Author

/retest

@guo-shaoge
refine
47cdf91 
Signed-off-by: guo-shaoge <[email protected]>
@guo-shaoge guo-shaoge requested a review from yibin87 January 7, 2025 03:46
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 7, 2025

@guo-shaoge: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-unit-test 47cdf91 link true /test pull-unit-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gengliqi gengliqi Awaiting requested review from gengliqi

@yibin87 yibin87 Awaiting requested review from yibin87

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support serialize/deserialize by column-wise for collator
1 participant
@guo-shaoge