From d46f457cc87d654302f987c9318bb22360ed7a1d Mon Sep 17 00:00:00 2001 From: ahalekelly <7078138+ahalekelly@users.noreply.github.com> Date: Thu, 29 Oct 2026 16:00:21 -0700 Subject: [PATCH] fix(core): flank strikethrough tildes like asterisk emphasis, matching GitHub Carries software-mansion-labs/md4c fix/strikethrough-flanking. md4c's tilde opener and closer checks each looked at only one side of the run, so `~$0.48 vs ~$0.65` and `~/foo and ~/bar` struck through on mobile while web (remark-gfm) and GitHub leave them plain, and intraword `a~~b~~c` did not strike. Co-Authored-By: Claude Opus 5.5 --- packages/core/cpp/enrmrkd/enrmrkd.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/packages/core/cpp/enrmrkd/enrmrkd.c b/packages/core/cpp/enrmrkd/enrmrkd.c index 2e81b534c..364e825cf 100644 --- a/packages/core/cpp/enrmrkd/enrmrkd.c +++ b/packages/core/cpp/enrmrkd/enrmrkd.c @@ -3618,13 +3618,15 @@ md_collect_marks(MD_CTX* ctx, const MD_LINE* lines, ENRMRKD_SIZE n_lines, int ta if(flags != 0) ADD_MARK(ch, off, tmp, flags); } else if(tmp - off <= 2 && (ctx->parser.flags & ENRMRKD_FLAG_STRIKETHROUGH)) { - /* Strikethrough: standard GFM left/right-flanking rules. */ - unsigned flags = MD_MARK_POTENTIAL_OPENER | MD_MARK_POTENTIAL_CLOSER; + /* Strikethrough: same flanking as `*` emphasis, as on GitHub. */ + int left_level = (off == line->beg || ISUNICODEWHITESPACEBEFORE(off)) ? 0 : (ISUNICODEPUNCTBEFORE(off) ? 1 : 2); + int right_level = (tmp == line->end || ISUNICODEWHITESPACE(tmp)) ? 0 : (ISUNICODEPUNCT(tmp) ? 1 : 2); + unsigned flags = 0; - if(off > line->beg && !ISUNICODEWHITESPACEBEFORE(off) && !ISUNICODEPUNCTBEFORE(off)) - flags &= ~MD_MARK_POTENTIAL_OPENER; - if(tmp < line->end && !ISUNICODEWHITESPACE(tmp) && !ISUNICODEPUNCT(tmp)) - flags &= ~MD_MARK_POTENTIAL_CLOSER; + if(left_level > 0 && left_level >= right_level) + flags |= MD_MARK_POTENTIAL_CLOSER; + if(right_level > 0 && right_level >= left_level) + flags |= MD_MARK_POTENTIAL_OPENER; if(flags != 0) ADD_MARK(ch, off, tmp, flags); }