Skip to content

Pad composer model picker to prevent ring clipping#1992

Merged
juliusmarminge merged 1 commit intomainfrom
t3code/fix-cut-off-ring
Apr 13, 2026
Merged

Pad composer model picker to prevent ring clipping#1992
juliusmarminge merged 1 commit intomainfrom
t3code/fix-cut-off-ring

Conversation

@juliusmarminge
Copy link
Copy Markdown
Member

@juliusmarminge juliusmarminge commented Apr 13, 2026

Before
image

After
CleanShot 2026-04-13 at 10 57 06@2x

Summary

  • Add padding around the composer model picker container so focus rings no longer get clipped.
  • Preserve the existing compact layout and horizontal scrolling behavior.

Testing

  • Not run (PR content only).
  • Visual check recommended for the composer footer focus ring in both compact and regular states.

Note

Low Risk
Small, CSS-only layout tweak to add padding around the composer footer model picker area; minimal functional risk beyond potential minor spacing/scroll behavior changes.

Overview
Adjusts the chat composer footer layout by adding padding (and compensating negative margin) to the horizontally scrollable container that wraps ProviderModelPicker, preventing focus rings from being clipped while keeping the compact/scrolling behavior.

Reviewed by Cursor Bugbot for commit 1dd1dfb. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Pad composer model picker to prevent focus ring clipping

Adds -m-1 p-1 to the provider/model picker container in ChatComposer.tsx so the focus ring is no longer clipped by the scrollable footer area.

Macroscope summarized 1dd1dfb.

- Add internal padding to the horizontal model picker row
- Keep focus ring visible when the picker scrolls
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 13, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 03e47098-d400-42f1-a93e-74d77974c02a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch t3code/fix-cut-off-ring

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Apr 13, 2026
@juliusmarminge juliusmarminge enabled auto-merge (squash) April 13, 2026 17:57
@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp bot commented Apr 13, 2026

Approvability

Verdict: Approved

Single-line CSS adjustment adding negative margin and padding to prevent focus ring clipping. Purely visual fix with no runtime behavior changes.

You can customize Macroscope's approvability policy. Learn more.

@juliusmarminge juliusmarminge merged commit f2205bd into main Apr 13, 2026
12 checks passed
@juliusmarminge juliusmarminge deleted the t3code/fix-cut-off-ring branch April 13, 2026 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant