fix(web): preserve selected model when changing reasoning effort#1999
fix(web): preserve selected model when changing reasoning effort#1999fgonzalezurriola wants to merge 1 commit intopingdotgg:mainfrom
Conversation
… reasoning effort
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved Straightforward bug fix that adds a fallback parameter to preserve the selected model when updating reasoning effort options. The change is minimal, well-tested, and has clear intent with no side effects outside the immediate fix. You can customize Macroscope's approvability policy. Learn more. |
IMPORTANT: i tried to fix it manually but gpt codex 5.3 xhigh explained me why i have skill issues, reviewed by my skill issued brain.
What Changed
closes #1844, preserving the selected base model when changing the reasoning effort
Why
bug in issue #1844 with certain state changing reasoning effort changes to the default model GPT5.4 (in codex)
imo changing between gpt-5.4-mini xhigh and gpt-5.4 medium/high helps into pushing further for $20 users, accidentally using gpt-5.4-xhigh has a huge impact for limits
UI Changes
None
Checklist
2026-04-13_15-51-15.mp4
Note
Medium Risk
Touches composer draft model-selection persistence logic; bugs here could cause unexpected model changes or incorrect sticky settings across threads/providers, but the change is small and covered by a targeted test.
Overview
Fixes a model-selection regression where changing provider traits (notably Codex
reasoningEffort) could reset the chosen model back to the provider default.TraitsPickernow passes the currently selectedmodelasbaseModelwhen persisting option changes, andcomposerDraftStore.setProviderModelOptionsaccepts/normalizes thisbaseModeland uses it when a draft/provider selection doesn’t exist yet (including sticky snapshots). Adds a unit test covering this “options update before selection exists” scenario.Reviewed by Cursor Bugbot for commit 87fbe87. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Preserve selected model when changing reasoning effort in chat composer
setProviderModelOptionsin composerDraftStore.ts to accept an optionalbaseModelparameter, used as the initial model when no model is currently set for the provider in draft or sticky state.baseModelwhen callingsetProviderModelOptions, so changing reasoning effort no longer resets the selected model.baseModelis reflected in both draft and sticky selections.Macroscope summarized 87fbe87.