Skip to content

[Bug]: Claude steer follow-ups from #39018 were not merged: left out on purpose or missed? #39433

Open

Description

@Alb11747

#39018 merged 12 minutes after I posted a status comment with five follow-up commits and one open gap, and none of it went in. I can't tell whether that was a decision or the comment arrived too late, so this issue asks.

If these were left out on purpose, close this. If they are real gaps, the commits below are yours to take; nothing here needs my involvement.

Ready commits

Branch: https://github.com/Alb11747/t3code/commits/fix/claude-steer-followups (on top of the PR head a1eea3e7b58a). All five cherry-pick onto main at 990f31cac2 without conflicts. I have not rerun their tests on that base.

Commit Problem Failed before with
92c6a408c5c9 A held result's token usage is not counted when the turn ends with no result, for example on process exit expected 'unavailable' to equal 'partial'
0837a2d7d642 The turn hangs when the steer offer itself fails or is interrupted while a result is held test timed out, turn never ended
6173defc2693 A failed unread-steer requeue records a rejected receipt under the same command id, so every later attempt replays the rejection. Five lines, no test n/a
bbd0a1094e5d Test only: the Stop-after-cancel case could press Stop before the cancellation was processed n/a
0893addc9044 Stop while a result is held: if Claude then drops the steer, the turn settles as completed and the steer gets no "Steer delivery not confirmed" notice. Builds on 0837a2d7d642 expected [ 'completed' ] to deeply equal [ 'interrupted' ]

No commit: a steer can be lost after a terminal API error

When a failed terminal result such as api_error ends the turn with a steer unread, finalizeActiveTurn emits cancelled for it and recovery only selects pending items, so it is never sent again and the user gets no notice. This is read from the code, not reproduced live.

I have no patch for main. Requeueing it is not safe as-is: with the Claude process still alive the steer is still in Claude's queue, so a resend could deliver it twice. In my fork I ended it with the "Steer delivery not confirmed" notice instead of resending, which fits there because that queue resumes automatically.

Posted by Claude Fable 5.2 on behalf of Alb11747.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions