fix: show restore defaults only on General settings#1710
fix: show restore defaults only on General settings#1710UtkarshUsername wants to merge 10 commits intopingdotgg:mainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
bot
added
size:S
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
ApprovabilityVerdict: Approved This is a simple UI fix that conditionally hides the 'Restore defaults' button on non-General settings pages. The change extracts a component and adds a pathname check - straightforward, self-contained, and low risk. You can customize Macroscope's approvability policy. Learn more. |
- Add a section header action for restoring defaults - Scope the restore button to General settings instead of the shared layout - Remove the layout-level refresh key workaround
- Show the restore defaults action from the shared settings shell - Keep the general settings panel focused on section content - Remount the outlet after restore so settings refresh cleanly
- Reserve header height so the restore defaults button no longer shifts layout - Keep the settings title row aligned on small screens
UtkarshUsername
force-pushed
the
fix/settings-restore-defaults-button
branch
from
0701dc2 to
f875f19
Compare
macroscopeapp
bot
dismissed
their stale review
Dismissing prior approval to re-evaluate f875f19
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e10cab0. Configure here.
- Move restore-defaults action into a reusable component - Keep post-restore refresh handling in the settings layout
- Remount the restore button after a restore completes - Keep both settings headers in sync via `restoreSignal`
github-actions
bot
added
size:M
macroscopeapp
bot
dismissed
their stale review
Dismissing prior approval to re-evaluate b8eceea
1 participant
Fixes #1709
What Changed
Moved the
Restore defaultsvisibility check into the shared settings header so the button keeps its existing placement but only renders on/settings/general.Also kept the web settings header height stable between General and Archive so the header does not visually jump when the button is absent.
Why
Restore defaultsresets general settings values. Showing it on the Archive page is misleading because that page is not a settings form and the action does not belong to that section. Also, the button doesn't work on the Archive page.Keeping the button in the shared header preserves the original UI placement, while route-gating it makes the behavior correct. Fixing the header height avoids a visual regression between settings routes.
UI Changes
Before:
After:
Checklist
I included a video for animation/interaction changesNote
Low Risk
Low risk UI change that only gates rendering of an existing button by route and adjusts header sizing; no data/model changes.
Overview
Limits the
Restore defaultsbutton to render only on/settings/generalby checkinguseLocation().pathname, avoiding showing a misleading action on other settings sub-routes.Adjusts the non-Electron settings header layout (
min-h-*) so the header height remains stable when the button is hidden, while keeping Electron and web headers consistent.Reviewed by Cursor Bugbot for commit e10cab0. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Show 'Restore defaults' button only on the General settings page
RestoreDefaultsButtoncomponent in settings.tsxuseLocationto check if the current path is/settings/general, and only rendersRestoreDefaultsButtonwhen it matchesMacroscope summarized b8eceea.