Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patched the timezones to map from old timezone to new one #609

Closed
wants to merge 9 commits into from
Closed

Patched the timezones to map from old timezone to new one #609

wants to merge 9 commits into from

Conversation

SachinBahukhandi
Copy link

Fixes: #603

@MrPunyapal
Copy link
Collaborator

We actually need a better solution 🤔

@SachinBahukhandi
Reverted back changes on frontend, and added the dateTime List valida…
82244aa 
…tion to validate against all the timezones(Backwards Compatible)
@SachinBahukhandi
Copy link
Author

We actually need a better solution 🤔

Actually yes, so I have added the changes to the backend, I used: DateTimeZone::listIdentifiers, and using it, we could be getting the deprecated timezones as well.

@MrPunyapal
Copy link
Collaborator

Can you add tests for the same? 🤔

@MrPunyapal
Copy link
Collaborator

Also can you revert the formatting in the blade file? 🤔

@SachinBahukhandi
Copy link
Author

Can you add tests for the same? 🤔

Please re-review.
Also reverted the app.blade.php.

@MrPunyapal
Copy link
Collaborator

MrPunyapal commented Sep 14, 2024 •
edited
Loading

Preferred file for such tests tests\Unit\Rules\ValidTimezoneTest.php.
Adding a few more time zones in the test would be good, like one in the issue itself.

@SachinBahukhandi
Copy link
Author

Preferred file for such tests tests\Unit\Rules\ValidTimezoneTest.php. Adding a few more time zones in the test would be good, like one in the issue itself.

Added please review.

@SachinBahukhandi @MrPunyapal
Update tests/Unit/Rules/ValidTimezoneTest.php
b25a39c 
Replaced the test by merging multiple cases into one.

Co-authored-by: Punyapal Shah  <[email protected]>
MrPunyapal
MrPunyapal approved these changes Sep 14, 2024
View reviewed changes
tests/Unit/Rules/ValidTimezoneTest.php Outdated Show resolved Hide resolved
@MrPunyapal MrPunyapal requested review from nunomaduro, steven-fox and CamKem and removed request for nunomaduro September 25, 2024 16:20
@nunomaduro
Copy link
Member

no plans to change this.

@nunomaduro nunomaduro closed this Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrPunyapal MrPunyapal MrPunyapal approved these changes

@steven-fox steven-fox Awaiting requested review from steven-fox

@CamKem CamKem Awaiting requested review from CamKem

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Asia/Katmandu is not a valid timezone
3 participants
@SachinBahukhandi @MrPunyapal @nunomaduro