Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Pulse from production #667

Open
nunomaduro opened this issue Sep 24, 2024 · 3 comments
Open

Remove Pulse from production #667

nunomaduro opened this issue Sep 24, 2024 · 3 comments
Assignees

Comments

@nunomaduro
Copy link
Member

No description provided.

@steven-fox
Copy link
Collaborator

Nuno, do we want to:

  1. Fully remove Pulse from the repo (remove dependency, update/remove migration, etc.)?
  2. Leave the code intact but disable via PULSE_ENABLED = false in .env?
  3. Alter the sampling for some of the recorders?
  4. Make a new sqlite database file specifically for pulse records that doesn't need to be backed up, can be vacuumed as needed, etc.?

I feel like keeping Pulse running on production for exceptions, and slow processing is wise before we migrate to something like Sentry.

Whatcha think?

@CamKem
Copy link
Collaborator

CamKem commented Sep 26, 2024

I think that's a good solution.

I don't think we need to remove pulse, it's useful for metrics other than exceptions too.

As your per suggestion: Isolating the pulse data is the key, Then the aggregate data is seperate from user data. We can setup to flatten the data or wipe the db periodically if needed.

@CamKem
Copy link
Collaborator

CamKem commented Sep 26, 2024

Sentry will be excellent upgrade for managing exceptions.

Moving jobs to horizon / Redis might also be worth considering during this process too, or at least put on the roadmap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants