[#noissue] Handle html error response #11197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <div className="flex items-center gap-1"> | ||
| <a | ||
| className="text-sm font-semibold text-primary hover:underline" | ||
| href={error?.url} |
There was a problem hiding this comment.
if error type is error: ErrorResponse & { url: string };, optional type is not necessary
or correct error type to error: ErrorResponse & { url?: string };
There was a problem hiding this comment.
Added new type ErrorDetailResponse and corrected error type.
binDongKim
force-pushed
the
handle-html-error-response
branch
from
bcb2f84
to
dffc7f5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11197 +/- ##
============================================
- Coverage 37.02% 37.00% -0.03%
+ Complexity 12047 12046 -1
============================================
Files 3974 3979 +5
Lines 97808 97869 +61
Branches 10410 10415 +5
============================================
Hits 36212 36212
- Misses 58617 58682 +65
+ Partials 2979 2975 -4 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.