Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change detected: poor performance on banana problem #973

Open
3 tasks
ben18785 opened this issue Sep 27, 2019 · 6 comments
Open
3 tasks

Change detected: poor performance on banana problem #973

ben18785 opened this issue Sep 27, 2019 · 6 comments
Labels

Comments

@ben18785
Copy link
Collaborator

ben18785 commented Sep 27, 2019

  • MALA
  • Relativistic MC
  • Hamiltonian MCMC

@MichaelClerx thanks for pointing these out!

@ben18785 ben18785 self-assigned this Sep 27, 2019
@MichaelClerx
Copy link
Member

Likely to be some issue in the derivatives of the banana problem, or maybe in the code that these methods share.

Now seeing MALA also performs badly on the normal test, which is a bit surprising and coudl be a separate issue?

@ben18785
Copy link
Collaborator Author

@MichaelClerx Just checked this -- it's because there isn't a gradient method implemented for multivariate Gaussians. I am surprised that we get any data from these runs as think it should just fail. Will create a separate issue to implement this (as should only take a few minutes and we should have it).

@MichaelClerx Is there a way to run the functional tests locally for a given method? Think it would be good to incorporate some degree of functional testing in our workflow of implementing new methods. Not sure how best to do this though...

@MichaelClerx
Copy link
Member

@MichaelClerx Just checked this -- it's because there isn't a gradient method implemented for multivariate Gaussians. I am surprised that we get any data from these runs as think it should just fail. Will create a separate issue to implement this (as should only take a few minutes and we should have it).

But the TwistedGaussianLogPDF does have an evaluateS1 method. Where do the multivariate gaussian distributions come in?

@ben18785
Copy link
Collaborator Author

ben18785 commented Sep 29, 2019 via email

@MichaelClerx
Copy link
Member

I didn't know they had a log prior in there!
But had a look and it's only used to generate the initial starting points, so the log prior's sensitivities don't come in to it

I am surprised that we get any data from these runs as think it should just fail.

This was right: calling evaluateS1() on a method that doesn't implement it will cause an exception!

@MichaelClerx
Copy link
Member

pints-team/change-point-testing#29

Not sure if this goes here or in the FT repo, so leaving open just now

@MichaelClerx MichaelClerx changed the title Investigate poor performance of samplers on banana problem Change detected: poor performance on banana problem Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants