Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local rtcp-fb values are used when answering #1968

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

digitalix
Copy link
Member

Description

Currently, pion uses remote rtcp-fb when answering.
According to https://tools.ietf.org/id/draft-ietf-rtcweb-sdp-08.html a=rtcp-fb lines should list supported feedback mechanisms. This change makes pion use rtcp-fb values provided by the user instead of using whatever was given by the remote pc.

Currently, pion uses remote rtcp-fb when answering.
According to https://tools.ietf.org/id/draft-ietf-rtcweb-sdp-08.html
a=rtcp-fb lines should list supported feedback mechanisms.
This change makes pion use rtcp-fb values provided by the
user.
@codecov
Copy link

codecov bot commented Sep 23, 2021

Codecov Report

Merging #1968 (b04c34e) into master (dce9704) will increase coverage by 0.05%.
The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1968      +/-   ##
==========================================
+ Coverage   76.96%   77.02%   +0.05%     
==========================================
  Files          85       85              
  Lines        6213     6224      +11     
==========================================
+ Hits         4782     4794      +12     
  Misses       1026     1026              
+ Partials      405      404       -1     
Flag Coverage Δ
go 78.80% <90.90%> (+0.05%) ⬆️
wasm 70.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mediaengine.go 90.75% <85.71%> (-0.12%) ⬇️
sdp.go 87.39% <100.00%> (+0.14%) ⬆️
icetransport.go 68.63% <0.00%> (+1.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dce9704...b04c34e. Read the comment docs.

@Sean-Der Sean-Der added this to the 3.2.0 milestone Jan 24, 2022
@Sean-Der Sean-Der removed this from the 3.2.0 milestone May 22, 2022
@edaniels
Copy link
Member

hey @digitalix , do you still want to work together to get this in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants