Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip some validation checks when BUNDLE group value is found #2735

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

stephanrotolante
Copy link
Contributor

Resolves #2621

Copy link

codecov bot commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.02%. Comparing base (c85269b) to head (ba42ddb).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2735      +/-   ##
==========================================
- Coverage   80.62%   79.02%   -1.60%     
==========================================
  Files          78       89      +11     
  Lines        7570     8295     +725     
==========================================
+ Hits         6103     6555     +452     
- Misses       1038     1267     +229     
- Partials      429      473      +44     
Flag Coverage Δ
go 80.62% <100.00%> (+<0.01%) ⬆️
wasm 64.98% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stephanrotolante stephanrotolante force-pushed the fix/bundle-conflicting-ufrag branch 3 times, most recently from c802217 to d961dd7 Compare April 19, 2024 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

RFC8843 : Accept offer with a=group:BUNDLE line even if it has conflicting ice-ufrag values
1 participant