-
-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add auto completion input type #1
Comments
+1 and the ability to switch through options using the tab key. |
+1 |
Appreciate the support of this feature but I may struggle to find time to add this atm. Suggestions for implementation or PRs would speed up the process. |
Here's an easy solution if you don't mind adding |
I think that using readline may be unnecessary(need more time to think this through though) as we already have a nice way to respond to any keystrokes, I think the matching behaviour is the key to get right. Thanks for the reference! |
It's been a long time and few things have improved in this library such as pagination of select menus. However, recently I have found out about really poor behaviour of this gem on Windows. Though, this is not the system of my choice I appreciate the fact that a lot of users may wish to install and use it on windows. For example kontena cli tool is using Therefore I'm currently rewriting how reading of character input works and testing it simultaneously on Windows. There is still plenty of code to be written but I'm making good progress and feel optimistic about the outcome. What that means to you? Well, once I finish the reading bit I have pretty much foundation ready to implement the autocomplete feature which will provide the readline capabilities, e.i. I wanted to update you on where I'm at and where things are going. I cannot promise a timeline but this is basically a next thing after Windows support is done. You can of course read the Windows issue to keep track. Thanks for your patience! |
@piotrmurach - I see some recent commits about Windows, so I'm wondering how Windows support is coming. I'd be interested to put in some time here to help you out in making pretty auto-complete prompts like those provided by Please let me know if there is work that I can pick up toward this effort (that doesn't involve Windows) that fits with your overall vision for this feature. |
@jemc - cheers for reaching out and offering to help! Firstly, the windows support was implemented in The most recent changes removed all keyboard input reading capabilities into a separate abstraction tty-reader. I haven't officially let anyone in on this library yet. Why do I mention this? It has a lot to do with this issue, namely, providing completion features. I believe this to be a really useful abstraction that I will use in different projects. My current thinking goes this way. The As a second part of the story, there would be a consumer class in I hope this kind of paints the picture a bit better. I don't think it's a quick job but definitely useful feature that would make this library super useful. If I were you I would probably look into ps. I'm currently working on releasing new |
Any news on this. Seems it would be the killer feature (at least for me :-) |
My work that I was doing on this is fairly suspended in an unfinished state - I'm not actively working on it at this time, unfortunately - I've had other open source contributions take precedence in my "free time". |
@rberger Great to hear your support for this feature. I've recently finished rewrite of tty-reader that powers input editing in this library. Next, it will allow me to build in support for completion. However, there are few open source projects I need to get done by the end of this month and I will be fairly busy in February so the soonest I will probably look into implementing this feature will be in March. I hope you understand. @jemc Whenever you have a minute to release what you've managed to do with tty gems would be great help. No pressure though as I fully understand the concept of open source in 'free time' as I've been doing it for quite a while 😅 |
(moved my comment to a separate issue, #70) |
+1 |
What's the status of this / how can I help? I want to implement a ruby alternative to the auto-completion menus found in python-prompt-toolkit. I'm currently interested in implementing this capability w/in a custom pry console used for prototyping automated security testing: https://github.com/ninp0/csi/blob/master/bin/csi |
@ninp0 Comments in this issue as well piotrmurach/tty-reader#2 show the current state of thinking. I don't have time to work on this feature, even though I would like to tackle the challenge of figuring out elegant API for |
Search source for a matching input and display matching list as characters are entered.
The text was updated successfully, but these errors were encountered: