Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idna compliant #49

Open
spirillen opened this issue Dec 29, 2021 · 8 comments · May be fixed by #51
Open

Idna compliant #49

spirillen opened this issue Dec 29, 2021 · 8 comments · May be fixed by #51

Comments

@spirillen
Copy link

You should convert sunrise domains into idna valid domains for broader support, rëddït.com = xn--rddt-lpa0a.com

||rëddït.com^$important,all

@piperun
Copy link
Owner

piperun commented Dec 29, 2021

Thanks for the issue! I'll look into it when I can (inactive due to injury).

@spirillen
Copy link
Author

Let's hope it ain't your head... I have enough of that myself for several good people.

I can make it rather ASAP with PyFunceble if you like, and the output in the files of #50 should already be IDNA formatted, Converted.

Answer to: #50

If you give me a should head up of what your idea is, I can make a PR on this, less work to you.

@piperun
Copy link
Owner

piperun commented Dec 30, 2021

It thankfully isn't! Hope your head also recovers well! 😅

#49
I would say create a new category (#) which is named something like:
# Idna compliant
and then the subcategory:
#blazse.com

#50
The general rule is to keep inactive domains since unless the domain owner has shown that the domain isn't owned by said ip logging company and that the current domain is used for "good" then it gets removed.

Happy new year!

@spirillen
Copy link
Author

Is this somewhat you had in mind https://github.com/dns-test/iploggerfilter ??

@piperun
Copy link
Owner

piperun commented Dec 31, 2021

Yes something like that, however when I compare yours with mine I'm noticing quite a lot of domains missing:

zzssfc.tk
tompriki.gr
tokdigitalexpress.com

to name a few.

@spirillen
Copy link
Author

They are probably in the inactive lists 😉

git grep 'zzssfc.tk'
Test_results/inactive.txt:||zzssfc.tk^$important,all

@piperun
Copy link
Owner

piperun commented Jan 2, 2022

I see, well for the sake of consistency it's better to have it be part of the main filterlist, since as long as the domain is simply inactive/invalid and hasn't changed owner it's better to be safe than sorry, if the current domain owners were to use the domain again.

@spirillen
Copy link
Author

I can do that,but then the hole idea behind taking the dead one away gone, the dead once in this results is DEAD on all levels, the only way they in 99% of the cases to reactivate these domains is by reregister them.

The test is set. so if one test reply an active, the result is active, it is a rather trustworthy result, the reason I left them in a separate file is, nothing is fail proof, and as you set, if they come back online. So next time you test them you just run the test on both file, if anything become a live you just reactive the rule 😄 In this way you should consider the rule de-activated, not deleted.

whois zzssfc.tk
The domain you requested is not known in Freenoms database.

@spirillen spirillen linked a pull request Jan 2, 2022 that will close this issue
spirillen added a commit to mypdns/matrix that referenced this issue Jan 3, 2022
This bulk import is done in trust to of good judgement from @piperun,
@D4v1dH03and non the less @iam-py-test3.

It all started with @D4v1dH03and issue
(easylist/easylist#10318). That lead to a full
test of active inactive records with @PyFunceble for validating the
actuality of the list and get a picture of the source credibility.

The test returned a 50/50 (IN)active records in
https://github.com/piperun/iploggerfilter/blob/master/filterlist. A
dialogue revealed @piperunkept outdated records "for in case of"

Related issues:
- easylist/easylist#10318
- piperun/iploggerfilter#51
- piperun/iploggerfilter#49
spirillen pushed a commit to mypdns/matrix that referenced this issue Jan 3, 2022
This bulk import is done in trust to of good judgement from @piperun
@D4v1dH03 @iam-py-test3.

It all started with @D4v1dH03and issue
(easylist/easylist#10318). That lead to a full
test of active inactive records with @PyFunceble for validating the
actuality of the list and get a picture of the source credibility.

The test returned a 50/50 (IN)active records in
https://github.com/piperun/iploggerfilter/blob/master/filterlist. A
dialogue revealed @piperun outdated records "for in case of"

Related issues:
- easylist/easylist#10318
- piperun/iploggerfilter#51
- piperun/iploggerfilter#49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants