-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Idna compliant #49
Comments
Thanks for the issue! I'll look into it when I can (inactive due to injury). |
Let's hope it ain't your head... I have enough of that myself for several good people. I can make it rather ASAP with PyFunceble if you like, and the output in the files of #50 should already be IDNA formatted, Converted. Answer to: #50 If you give me a should head up of what your idea is, I can make a PR on this, less work to you. |
It thankfully isn't! Hope your head also recovers well! 😅 #49 #50 Happy new year! |
Is this somewhat you had in mind https://github.com/dns-test/iploggerfilter ?? |
Yes something like that, however when I compare yours with mine I'm noticing quite a lot of domains missing:
to name a few. |
They are probably in the inactive lists 😉
|
I see, well for the sake of consistency it's better to have it be part of the main filterlist, since as long as the domain is simply inactive/invalid and hasn't changed owner it's better to be safe than sorry, if the current domain owners were to use the domain again. |
I can do that,but then the hole idea behind taking the dead one away gone, the dead once in this results is DEAD on all levels, the only way they in 99% of the cases to reactivate these domains is by reregister them. The test is set. so if one test reply an active, the result is active, it is a rather trustworthy result, the reason I left them in a separate file is, nothing is fail proof, and as you set, if they come back online. So next time you test them you just run the test on both file, if anything become a live you just reactive the rule 😄 In this way you should consider the rule de-activated, not deleted.
|
This bulk import is done in trust to of good judgement from @piperun, @D4v1dH03and non the less @iam-py-test3. It all started with @D4v1dH03and issue (easylist/easylist#10318). That lead to a full test of active inactive records with @PyFunceble for validating the actuality of the list and get a picture of the source credibility. The test returned a 50/50 (IN)active records in https://github.com/piperun/iploggerfilter/blob/master/filterlist. A dialogue revealed @piperunkept outdated records "for in case of" Related issues: - easylist/easylist#10318 - piperun/iploggerfilter#51 - piperun/iploggerfilter#49
This bulk import is done in trust to of good judgement from @piperun @D4v1dH03 @iam-py-test3. It all started with @D4v1dH03and issue (easylist/easylist#10318). That lead to a full test of active inactive records with @PyFunceble for validating the actuality of the list and get a picture of the source credibility. The test returned a 50/50 (IN)active records in https://github.com/piperun/iploggerfilter/blob/master/filterlist. A dialogue revealed @piperun outdated records "for in case of" Related issues: - easylist/easylist#10318 - piperun/iploggerfilter#51 - piperun/iploggerfilter#49
You should convert sunrise domains into idna valid domains for broader support,
rëddït.com = xn--rddt-lpa0a.com
iploggerfilter/filterlist
Line 66 in 820a540
The text was updated successfully, but these errors were encountered: