-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Idna compliant #51
base: master
Are you sure you want to change the base?
Idna compliant #51
Conversation
Tested with PyFunceble Kept the lists of INACTIVE + INVALID as requested in and #49 A new category have also been added at the buttom of the filterlist with the IDNA records sorted by subcategory.
Just to have a second look on these records @D4v1dH03 tested them as well, even I only expected a selective test, it turned out he tested them all, Lovely guy. |
This bulk import is done in trust to of good judgement from @piperun, @D4v1dH03and non the less @iam-py-test3. It all started with @D4v1dH03and issue (easylist/easylist#10318). That lead to a full test of active inactive records with @PyFunceble for validating the actuality of the list and get a picture of the source credibility. The test returned a 50/50 (IN)active records in https://github.com/piperun/iploggerfilter/blob/master/filterlist. A dialogue revealed @piperunkept outdated records "for in case of" Related issues: - easylist/easylist#10318 - piperun/iploggerfilter#51 - piperun/iploggerfilter#49
This bulk import is done in trust to of good judgement from @piperun @D4v1dH03 @iam-py-test3. It all started with @D4v1dH03and issue (easylist/easylist#10318). That lead to a full test of active inactive records with @PyFunceble for validating the actuality of the list and get a picture of the source credibility. The test returned a 50/50 (IN)active records in https://github.com/piperun/iploggerfilter/blob/master/filterlist. A dialogue revealed @piperun outdated records "for in case of" Related issues: - easylist/easylist#10318 - piperun/iploggerfilter#51 - piperun/iploggerfilter#49
Looks alright, you wouldn't mind adding the test code you use to look into if the DNS is active/invalid? |
Sure, it is based on our (@funilrys and me) Pyfunceble templates They might need some tweaking to match pyfunceble version 4.x But in your case the command line code should be looking something like this: Installing PyFunceble
Executing PyFunceble test from command lineThen copy this Here is the relevant docs https://pyfunceble.readthedocs.io/en/dev/usage/index.html#from-a-terminal
That is actually about it The pitfall in this is your adblock rules are not copied, but as you are using one rule, this is fastly added by a script. The un-official docs repo is here https://mypdns.org/spirillen/PyFunceble |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After a very long time (sorry about that), I think this should work.
@rebase needed |
Tested with PyFunceble
Kept the lists of INACTIVE + INVALID as requested in and
#49
A new category have also been added at the bottom of the filterlist
with the IDNA records sorted by subcategory.
Closes #50
Closes #49