Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idna compliant #51

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Idna compliant #51

wants to merge 3 commits into from

Conversation

spirillen
Copy link

Tested with PyFunceble

Kept the lists of INACTIVE + INVALID as requested in and
#49

A new category have also been added at the bottom of the filterlist
with the IDNA records sorted by subcategory.

Closes #50

Closes #49

Tested with PyFunceble

Kept the lists of INACTIVE + INVALID as requested in and
#49

A new category have also been added at the buttom of the filterlist
with the IDNA records sorted by subcategory.
@spirillen
Copy link
Author

Just to have a second look on these records @D4v1dH03 tested them as well, even I only expected a selective test, it turned out he tested them all, Lovely guy.

easylist/easylist#10318 (comment)

spirillen added a commit to mypdns/matrix that referenced this pull request Jan 3, 2022
This bulk import is done in trust to of good judgement from @piperun,
@D4v1dH03and non the less @iam-py-test3.

It all started with @D4v1dH03and issue
(easylist/easylist#10318). That lead to a full
test of active inactive records with @PyFunceble for validating the
actuality of the list and get a picture of the source credibility.

The test returned a 50/50 (IN)active records in
https://github.com/piperun/iploggerfilter/blob/master/filterlist. A
dialogue revealed @piperunkept outdated records "for in case of"

Related issues:
- easylist/easylist#10318
- piperun/iploggerfilter#51
- piperun/iploggerfilter#49
spirillen pushed a commit to mypdns/matrix that referenced this pull request Jan 3, 2022
This bulk import is done in trust to of good judgement from @piperun
@D4v1dH03 @iam-py-test3.

It all started with @D4v1dH03and issue
(easylist/easylist#10318). That lead to a full
test of active inactive records with @PyFunceble for validating the
actuality of the list and get a picture of the source credibility.

The test returned a 50/50 (IN)active records in
https://github.com/piperun/iploggerfilter/blob/master/filterlist. A
dialogue revealed @piperun outdated records "for in case of"

Related issues:
- easylist/easylist#10318
- piperun/iploggerfilter#51
- piperun/iploggerfilter#49
@piperun
Copy link
Owner

piperun commented Jan 4, 2022

Looks alright, you wouldn't mind adding the test code you use to look into if the DNS is active/invalid?

@spirillen
Copy link
Author

spirillen commented Jan 4, 2022

Sure, it is based on our (@funilrys and me) Pyfunceble templates They might need some tweaking to match pyfunceble version 4.x

But in your case the command line code should be looking something like this:

Installing PyFunceble

Dev (Usual rather stable and the only one I use)
python3.10 -m pip install -I -U --pre pyfunceble-dev

Stable
python3.10 -m pip install -I -U pyfunceble

Executing PyFunceble test from command line

Then copy this .PyFunceble.overwrite.yaml to ~/.config/PyFunceble/.PyFunceble.overwrite.yaml Change values as you sees fit

Here is the relevant docs https://pyfunceble.readthedocs.io/en/dev/usage/index.html#from-a-terminal

pyfunceble --adblock -f filterlist Test_results/inactive.txt

That is actually about it

The pitfall in this is your adblock rules are not copied, but as you are using one rule, this is fastly added by a script.

The un-official docs repo is here https://mypdns.org/spirillen/PyFunceble

Copy link
Owner

@piperun piperun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After a very long time (sorry about that), I think this should work.

@spirillen
Copy link
Author

After a very long time (sorry about that), I think this should work.

@rebase needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plenty of dead records (PyFunceble) Idna compliant
2 participants