From c33934ef9f6f140ce4a0e0a7f1d45905f48156ff Mon Sep 17 00:00:00 2001 From: Christopher Hunter Date: Fri, 7 Jul 2023 11:15:24 -0700 Subject: [PATCH] fix cilint failures these were introduced in a different PR --- internal/builder/release_manifest_reader.go | 4 ---- internal/builder/release_manifest_reader_test.go | 6 +++--- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/internal/builder/release_manifest_reader.go b/internal/builder/release_manifest_reader.go index 5381b8f3e..29cd34289 100644 --- a/internal/builder/release_manifest_reader.go +++ b/internal/builder/release_manifest_reader.go @@ -19,10 +19,6 @@ type ReleaseManifest struct { StemcellVersion string `yaml:"-"` } -type compiledPackage struct { - Stemcell string `yaml:"stemcell"` -} - type ReleaseManifestReader struct { fs billy.Filesystem } diff --git a/internal/builder/release_manifest_reader_test.go b/internal/builder/release_manifest_reader_test.go index e18deeb57..48c8193d9 100644 --- a/internal/builder/release_manifest_reader_test.go +++ b/internal/builder/release_manifest_reader_test.go @@ -6,7 +6,7 @@ import ( "bytes" "compress/gzip" "crypto/sha1" - "fmt" + "encoding/hex" "io" "os" "path/filepath" @@ -59,7 +59,7 @@ func createReleaseTarball(releaseMetadata string) (*os.File, string) { _, err = io.Copy(hash, file) Expect(err).NotTo(HaveOccurred()) - releaseSHA1 := fmt.Sprintf("%x", hash.Sum(nil)) + releaseSHA1 := hex.EncodeToString(hash.Sum(nil)) err = file.Close() Expect(err).NotTo(HaveOccurred()) @@ -220,7 +220,7 @@ version: 1.2.3 Expect(err).NotTo(HaveOccurred()) _, err = reader.Read(tarball.Name()) - Expect(err).To(MatchError(fmt.Sprintf("failed to find release.MF in tarball"))) + Expect(err).To(MatchError("failed to find release.MF in tarball")) }) })